[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Several new utilities for KDE: KLook and StackFolder
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2012-05-07 17:21:19
Message-ID: CAExHGmQrmg=y7irUNLbtqfvoajb1iT_YFqqH-dhNKja1ebNeGw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

On Mon, May 7, 2012 at 7:15 PM, David Edmundson
<david@davidedmundson.co.uk>wrote:

> Good to see these merged into playground!
>
> Some things we would need to proposing for KDE extragear/core
> - Watch your coding style
>  http://techbase.kde.org/Policies/Kdelibs_Coding_Style
>  In particular:
>    Always use braces
>    Don't call classes "MySomething". As the "My" isn't very helpful
>    Make sure the files actually match the names of the class.
> audio.h, video.h, text.h
>    MyAudio::~MyAudio() use m_mediaObject->deleteLater(); instead of
> delete (it's safer). Alternatively set a parent on it in the
> constructor and don't manually delete it.
>   Technically your whitespace is off in many ways too, but that's
> being pedantic.
>

Unlike what many people think the mentioned web-page is the coding-style
for kdelibs only. Other kde projects/modules may choose to adopt that style
or parts of the style, but its not mandatory for any module to follow it.
You're always free to choose whatever style suits you.

Andreass

[Attachment #5 (text/html)]

Hi,<br><br><div class="gmail_quote">On Mon, May 7, 2012 at 7:15 PM, David \
Edmundson <span dir="ltr">&lt;<a href="mailto:david@davidedmundson.co.uk" \
target="_blank">david@davidedmundson.co.uk</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> Good to see these merged \
into playground!<br> <br>
Some things we would need to proposing for KDE extragear/core<br>
- Watch your coding style<br>
  <a href="http://techbase.kde.org/Policies/Kdelibs_Coding_Style" \
target="_blank">http://techbase.kde.org/Policies/Kdelibs_Coding_Style</a><br>
  In particular:<br>
    Always use braces<br>
    Don&#39;t call classes &quot;MySomething&quot;. As the &quot;My&quot; \
isn&#39;t very helpful<br>  Make sure the files actually match the names of \
the class.<br> audio.h, video.h, text.h<br>
    MyAudio::~MyAudio() use m_mediaObject-&gt;deleteLater(); instead of<br>
delete (it&#39;s safer). Alternatively set a parent on it in the<br>
constructor and don&#39;t manually delete it.<br>
   Technically your whitespace is off in many ways too, but that&#39;s<br>
being pedantic.<br></blockquote><div><br></div><div>Unlike what many people \
think the mentioned web-page is the coding-style for kdelibs only. Other \
kde projects/modules may choose to adopt that style or parts of the style, \
but its not mandatory for any module to follow it. You&#39;re always free \
to choose whatever style suits you.</div> \
<div><br></div><div>Andreass</div></div>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]