[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Uploading .diff files on reviewboard
From:       Rahul Sharma <rahulveera2009 () gmail ! com>
Date:       2012-03-01 11:57:11
Message-ID: CAC3EFMgQhc_9w5Bnp2Q-zMpZ=0ePzKrO-CmifWaWSDWEwJ6M6Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Thomas,
I created the diff the same way as you said and perhaps reviewboard
accepted that. But I encountered another error. It says:
*The file 'home/rahul/kmplot/kmplot/ksliderwindow.cpp' (r7ca8503) could not
be found in the repository. *after I have uploaded my diff.

And I don't know what does that mean. So, could you please tell me?

Regards,
Rahul Sharma.

On Mon, Feb 27, 2012 at 2:18 AM, Thomas L=FCbking
<thomas.luebking@gmail.com>wrote:

> Am 26.02.2012, 20:30 Uhr, schrieb Rahul Sharma <rahulveera2009@gmail.com>=
:
>
>
>  Hi,
>> I am trying to upload my .diff file on the reviewboard through the web U=
I
>> for reviewboard, but I am getting error.
>> It always says that the file I uploaded is not .diff file even I am
>> uploading the file of the .diff extension.
>>
>> Any suggestions??
>>
>
> The reviewboard is pretty picky about diffs.
> Create them using "git diff <hash>" of "git format-patch <hash>", eg
> git format-patch HEAD~3
> will create diffs for the 3 latest commits
> while
> git diff HEAD~2
> will create one patch against the branch as it was two commits ago.
>
> The reviewboard will also reject diffs against hashes it doesn't know
> (because they only exist in your local branch) - for this purpose you can
> create a diff agains a common hash and supply that as parenting patch.
>
>
> Cheers,
> Thomas
>
>
>  Visit http://mail.kde.org/mailman/**listinfo/kde-devel#unsub<http://mail=
.kde.org/mailman/listinfo/kde-devel#unsub>to unsubscribe <<
>>>
>>

[Attachment #5 (text/html)]

Hi Thomas,<br>I created the diff the same way as you said and perhaps reviewboard \
accepted that. But I encountered another error. It says:<br><b><u>The file \
&#39;home/rahul/kmplot/kmplot/ksliderwindow.cpp&#39; (r7ca8503) could not be found in \
the repository</u>. </b>after I have uploaded my diff.<br>

<br>And I don&#39;t know what does that mean. So, could you please tell \
me?<br><br>Regards,<br>Rahul Sharma.<br><br><div class="gmail_quote">On Mon, Feb 27, \
2012 at 2:18 AM, Thomas Lübking <span dir="ltr">&lt;<a \
href="mailto:thomas.luebking@gmail.com">thomas.luebking@gmail.com</a>&gt;</span> \
wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Am 26.02.2012, 20:30 Uhr, schrieb Rahul Sharma &lt;<a \
href="mailto:rahulveera2009@gmail.com" \
target="_blank">rahulveera2009@gmail.com</a>&gt;:<div>

<div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
I am trying to upload my .diff file on the reviewboard through the web UI<br>
for reviewboard, but I am getting error.<br>
It always says that the file I uploaded is not .diff file even I am<br>
uploading the file of the .diff extension.<br>
<br>
Any suggestions??<br>
</blockquote>
<br></div></div>
The reviewboard is pretty picky about diffs.<br>
Create them using &quot;git diff &lt;hash&gt;&quot; of &quot;git format-patch \
&lt;hash&gt;&quot;, eg<br> git format-patch HEAD~3<br>
will create diffs for the 3 latest commits<br>
while<br>
git diff HEAD~2<br>
will create one patch against the branch as it was two commits ago.<br>
<br>
The reviewboard will also reject diffs against hashes it doesn&#39;t know (because \
they only exist in your local branch) - for this purpose you can create a diff agains \
a common hash and supply that as parenting patch.<br>


<br>
<br>
Cheers,<br>
Thomas<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/<u></u>listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> </blockquote></blockquote>
</div></div></blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]