[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: unable to build kdenetwork from master
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2011-08-07 4:48:34
Message-ID: CADWV2K5LpE3Yy8Mt5BM2LcE3o2J2BvafVMX+0RNSJRJjhJ9ZpA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Ok, just committed my fix to kopete on the trunk and 4.7 branches.
Enjoy.
On Thu, Aug 4, 2011 at 7:50 AM, Jeremy Whiting <jpwhiting@kde.org> wrote:
> Jovie is fixed on 4.7 branch and master branch. I sent a patch to
> kopete-devel and kde-core-devel that fixes kdenetwork just now, any comments
> welcome.
>
> thanks,
> Jeremy
>
> On Tue, Aug 2, 2011 at 3:24 PM, Thiago Macieira <thiago@kde.org> wrote:
>
>> On Tuesday, 2 de August de 2011 14:19:07 Raphael Kubo da Costa wrote:
>> > There's also the upstream bug:
>> > https://bugreports.qt.nokia.com/browse/QTBUG-19717
>>
>> It's not an upstream bug as virtually inheriting isn't necessary. QObject
>> cannot be multiply-inherited and none of the Qt classes inherit it
>> virtually.
>>
>> Since virtual inheritance causes overhead (code size, class size,
>> run-time)
>> and you don't need it, QObject doesn't need to support it either.
>>
>> So please fix the code that tries to do that.
>> --
>> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>> Software Architect - Intel Open Source Technology Center
>> PGP/GPG: 0x6EF45358; fingerprint:
>> E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
>>
>>
>> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>> unsubscribe <<
>>
>>
>
[Attachment #5 (text/html)]
Ok, just committed my fix to kopete on the trunk and 4.7 \
branches.<br><br>Enjoy.<br><br><div class="gmail_quote">On Thu, Aug 4, 2011 at 7:50 \
AM, Jeremy Whiting <span dir="ltr"><<a \
href="mailto:jpwhiting@kde.org">jpwhiting@kde.org</a>></span> wrote:<br> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;">Jovie is fixed on 4.7 branch and master branch. I sent a \
patch to kopete-devel and kde-core-devel that fixes kdenetwork just now, any comments \
welcome.<br> <br>thanks,<br><font color="#888888">Jeremy<br><br></font><div \
class="gmail_quote"><div><div></div><div class="h5">On Tue, Aug 2, 2011 at 3:24 PM, \
Thiago Macieira <span dir="ltr"><<a href="mailto:thiago@kde.org" \
target="_blank">thiago@kde.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div><div></div><div class="h5"><div>On Tuesday, 2 de \
August de 2011 14:19:07 Raphael Kubo da Costa wrote:<br>
> There's also the upstream bug:<br>
> <a href="https://bugreports.qt.nokia.com/browse/QTBUG-19717" \
target="_blank">https://bugreports.qt.nokia.com/browse/QTBUG-19717</a><br> <br>
</div>It's not an upstream bug as virtually inheriting isn't necessary. \
QObject<br> cannot be multiply-inherited and none of the Qt classes inherit it \
virtually.<br> <br>
Since virtual inheritance causes overhead (code size, class size, run-time)<br>
and you don't need it, QObject doesn't need to support it either.<br>
<br>
So please fix the code that tries to do that.<br>
<div>--<br>
Thiago Macieira - thiago (AT) <a href="http://macieira.info" \
target="_blank">macieira.info</a> - thiago (AT) <a href="http://kde.org" \
target="_blank">kde.org</a><br> </div> Software Architect - Intel Open Source \
Technology Center<br> <div><div></div><div> PGP/GPG: 0x6EF45358; \
fingerprint:<br> E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358<br>
</div></div><br><br></div></div><div class="im">
>> Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe <<<br> <br></div></blockquote></div><br>
</blockquote></div><br>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic