[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: unable to build kdenetwork from master
From:       Jeremy Whiting <jpwhiting () kde ! org>
Date:       2011-08-04 13:50:32
Message-ID: CADWV2K5keWPrgO_YFGhhxRV0xNfRuSw4=9kO8H_cv0LG=5SCCA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Jovie is fixed on 4.7 branch and master branch.  I sent a patch to
kopete-devel and kde-core-devel that fixes kdenetwork just now, any comments
welcome.

thanks,
Jeremy

On Tue, Aug 2, 2011 at 3:24 PM, Thiago Macieira <thiago@kde.org> wrote:

> On Tuesday, 2 de August de 2011 14:19:07 Raphael Kubo da Costa wrote:
> > There's also the upstream bug:
> > https://bugreports.qt.nokia.com/browse/QTBUG-19717
>
> It's not an upstream bug as virtually inheriting isn't necessary. QObject
> cannot be multiply-inherited and none of the Qt classes inherit it
> virtually.
>
> Since virtual inheritance causes overhead (code size, class size, run-time)
> and you don't need it, QObject doesn't need to support it either.
>
> So please fix the code that tries to do that.
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>       PGP/GPG: 0x6EF45358; fingerprint:
>      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>

[Attachment #5 (text/html)]

Jovie is fixed on 4.7 branch and master branch.  I sent a patch to kopete-devel and \
kde-core-devel that fixes kdenetwork just now, any comments \
welcome.<br><br>thanks,<br>Jeremy<br><br><div class="gmail_quote">On Tue, Aug 2, 2011 \
at 3:24 PM, Thiago Macieira <span dir="ltr">&lt;<a \
href="mailto:thiago@kde.org">thiago@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"><div class="im">On Tuesday, 2 de August de 2011 14:19:07 \
Raphael Kubo da Costa wrote:<br> &gt; There&#39;s also the upstream bug:<br>
&gt; <a href="https://bugreports.qt.nokia.com/browse/QTBUG-19717" \
target="_blank">https://bugreports.qt.nokia.com/browse/QTBUG-19717</a><br> <br>
</div>It&#39;s not an upstream bug as virtually inheriting isn&#39;t necessary. \
QObject<br> cannot be multiply-inherited and none of the Qt classes inherit it \
virtually.<br> <br>
Since virtual inheritance causes overhead (code size, class size, run-time)<br>
and you don&#39;t need it, QObject doesn&#39;t need to support it either.<br>
<br>
So please fix the code that tries to do that.<br>
<div class="im">--<br>
Thiago Macieira - thiago (AT) <a href="http://macieira.info" \
target="_blank">macieira.info</a> - thiago (AT) <a href="http://kde.org" \
target="_blank">kde.org</a><br> </div>   Software Architect - Intel Open Source \
Technology Center<br> <div><div></div><div class="h5">      PGP/GPG: 0x6EF45358; \
fingerprint:<br>  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358<br>
</div></div><br><br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> <br></blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]