[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KTipDialog deletes KTipDatabase in destuctor
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-01-11 18:31:11
Message-ID: 201001111031.12404.aseigo () kde ! org
[Download RAW message or body]

On January 10, 2010, Stéphane MANKOWSKI wrote:
> So, I would like to have your opinion.
> Is it a bug or not ?

yes, that is a poorly designed API. we can't change the behavior of it now, 
however, without causing memory leaks in all the other application that use it 
currently. so i don't think we can adjust it now. i have added API 
documentation to note that this is the case and when we next break binary 
compatibility we can change this API to be more sensible (e.g. take the tip 
database by reference and use a shared dptr to store the data; aka the classic 
shallow-copy pattern we all know and love from elsewhere in Qt and KDE classes 
:)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]