[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KPPP
From:       Harri Porten <porten () froglogic ! com>
Date:       2008-12-19 20:42:36
Message-ID: Pine.LNX.4.64.0812192139540.24031 () pudel ! froglogic ! com
[Download RAW message or body]

Hello,

On Fri, 19 Dec 2008, Urs Wolfer wrote:

>> Along the way I will make small change: if Provider config file has
>> Password= and Username= fields with no %USERNAME% or %PASSWORD% in
>> them,
>> then auth-info page won't be shown, as there is no sense specifying
>> any info there because it will be ignored anyway (also true for
>> previous kppp versions).
>> If you rgrep Password=[^%] kppp/DB/Providers you'll see that there are
>> several files that define fixed login/password.
>> There are cases when auth info isn't needed. For example, this is the
>> case for GPRS/EDGE connections.
>> Currently, when faced with such provider config file, a user (she or
>> he) will be confused by the auth info page.

Makes sense.

>> As those changes are UI-only and hence easy to test, I believe my
>> commit won't cause new bugs appearing in KDE 4.2 release, but instead
>> will improve the kppp experience.
>
> Sounds like simple changes. Do you mind posting the patch here? If it looks
> okay, and you feel good about the changes, I see no problem with committing
> it.
>
> Btw, I'm happy to see some activity in KPPP since it is quite unmaintained...

Unfortunately, yes. Lacking the necessary hardware I can't do more than 
review patches. Maybe Nick will one day .... :)

Harri.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]