[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Dolphin Patch ?
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2008-06-28 11:23:40
Message-ID: 200806281323.41137.aacid () kde ! org
[Download RAW message or body]

A Dissabte 28 Juny 2008, Peter Penz va escriure:
> On Saturday, 28. June 2008 13:07:04 Albert Astals Cid wrote:
> > A Dissabte 28 Juny 2008, Andreas Scherf va escriure:
> > > Hello,
> > > i changed one thing in the selection part of the dolphin main window.
> > > Everytime 2 files/dirs are selected dolphin searches for "kompare".
> > > I think that we could test this only once to safe time. If somebody
> > > install/removes compare while running dolphin he couldn't use kompare.
> > > But i think the runtime costs are reduced. Ok ?
> >
> > Errrr, not speaking about your patch, but it's really really really using
> > having a hardcoded "kompare" there, can't kompare just use servicemenus
> > as everybody else does?
>
> I agree that a hardcoded "kompare" is not nice, but there is currently no
> mechanism that the service menu tells the using application that the
> service only works for e. g. 2 selections. Any suggestion to improve this
> situation are for sure welcome.

Are you sure? kdiff3plugin.cpp[1] seems to handle that quite ok.

Albert

[1] 
http://websvn.kde.org/trunk/playground/devtools/kdiff3/kdiff3plugin/kdiff3plugin.cpp?view=markup

>
> Peter
>
> > Albert
> >
> > > Andreas
> > >
> > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> > >> unsubscribe <<
> >>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<


 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]