[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Patch] KPTY and CTRL() macro -> use CFOO constants?
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2008-06-28 6:57:14
Message-ID: 20080628065714.GA23091 () ugly ! local
[Download RAW message or body]

On Fri, Jun 27, 2008 at 03:32:06PM +0200, Ed Schouten wrote:
> 	CTRL('c')	-> 0x03
> 
> Because this translation is broken by design (you need the translation
> to be performed on uppercase characters to be correct),
>
huh? i admit that it is somewhat weird (the asymmetry with CERASE
bothers me), but what is wrong with this?

#define CTRL(x) ((x) & 037)

it should work with both lower and upper case and with the bogus
values passed by the kde code. i venture the guess that your "fix" in
the header will in fact break quite a lot ...

> I heard this code is also present in KDE4.
> 
in fact, it's not ... it is just setting what is default anyway, so i
purged it some time ago.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]