[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: KHTML color scheme patch
From: "=?ISO-8859-1?Q?Percy_Camilo_Trive=F1o_Aucahuasi?=" <orgyforever () gmail ! com>
Date: 2008-06-27 22:38:12
Message-ID: 579229230806271538o1b60fc29veb2e34601594e174 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi, I built khtml and konqueror (this last without need it :)), the patch
break completly the configuration of the styleshet, all the settings doesn't
work becouse the background color always is white and the foreground color
is black. Also konqueror is crashing on exit.
I'm attaching the bugtrace (btrace.txt), I don't know how works khtml to
paint the pages but certainly it can't show all the pages when the
background (and foreground) isn't the default. Perhaps the patch should use
KStatefulBrush and KColorScheme::* instead QPalette.
Percy
On 6/27/08, Matthew Woehlke <mw_triad@users.sourceforge.net> wrote:
>
> Conor W Sullivan wrote:
> > Hi, where is the best place to discuss khtml issues? The following is a
> patch
> > to kdelibs/khtml/khtml_part.cpp which simply sets the part's color scheme
> as
> > being a generic black-on-white color scheme. This is because khtml often
> > works with webpages that conflict severly with dark color schemes. I can
> add a
> > system settings option to disable this is you like.
>
> IMO forcing the color palette to ignore user settings is a major step
> backwards (not to mention a huge u7y/a11y no-no). I would *much* rather
> see khtml be smart enough to detect brain-dead pages and fix them... not
> only for this issue, but to be honest, I'd like it to "fix" pages that
> intentionally try to obfuscate text by making it, say, black-on-black.
>
> KColorUtils::contrastRatio was created for exactly this sort of thing. A
> quick fix is, assuming you know the background color, replace the
> requested foreground color with KCU::tint(askedFG, ref) where "ref" is
> black if KCU::luma(background) > 0.5 and white otherwise.
>
> (Actually, I'd like to further see if the requested foreground is black
> and no background was requested i.e. we're using the default, ignore the
> foreground request and use the default foreground. Since this is how
> most pages screw up anyway...)
>
>
> --
> Matthew
> First time I've gotten a programming job that required a drug test. I
> was worried they were going to say 'you don't have enough LSD in your
> system to do Unix programming'. -- Paul Tomblin (from cluefire.net)
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
[Attachment #5 (text/html)]
Hi, I built khtml and konqueror (this last without need it :)), the
patch break completly the configuration of the styleshet, all the
settings doesn't work becouse the background color always is white and
the foreground color is black. Also konqueror is crashing on exit.<br>
<br>I'm attaching the bugtrace (btrace.txt), I don't know how works
khtml to paint the pages but certainly it can't show all the pages when
the background (and foreground) isn't the default. Perhaps the patch
should use KStatefulBrush and KColorScheme::* instead QPalette.<br>
<br>Percy<br><br><br><br><div><span class="gmail_quote">On 6/27/08, <b \
class="gmail_sendername">Matthew Woehlke</b> <<a \
href="mailto:mw_triad@users.sourceforge.net">mw_triad@users.sourceforge.net</a>> \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Conor W Sullivan \
wrote:<br> > Hi, where is the best place to discuss khtml issues? The \
following is a patch<br> > to kdelibs/khtml/khtml_part.cpp which simply sets the \
part's color scheme as<br> > being a generic black-on-white color \
scheme. This is because khtml often<br> > works with webpages that \
conflict severly with dark color schemes. I can add a<br> > system \
settings option to disable this is you like.<br> <br> IMO forcing the color palette \
to ignore user settings is a major step<br> backwards (not to mention a huge \
u7y/a11y no-no). I would *much* rather<br> see khtml be smart enough to detect \
brain-dead pages and fix them... not<br> only for this issue, but to be honest, \
I'd like it to "fix" pages that<br> intentionally try to obfuscate \
text by making it, say, black-on-black.<br> <br> KColorUtils::contrastRatio was \
created for exactly this sort of thing. A<br> quick fix is, assuming you know the \
background color, replace the<br> requested foreground color with KCU::tint(askedFG, \
ref) where "ref" is<br> black if KCU::luma(background) > 0.5 and white \
otherwise.<br> <br> (Actually, I'd like to further see if the requested \
foreground is black<br> and no background was requested i.e. we're using the \
default, ignore the<br> foreground request and use the default foreground. Since this \
is how<br> most pages screw up anyway...)<br> <br><br> --<br> Matthew<br> First time \
I've gotten a programming job that required a drug test. I<br> was worried they \
were going to say 'you don't have enough LSD in your<br> system to do Unix \
programming'. -- Paul Tomblin (from <a \
href="http://cluefire.net">cluefire.net</a>)<br> <br> <br> >> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> \
to unsubscribe <<<br> </blockquote></div><br>
["btrace.kcrash" (application/octet-stream)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic