[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KHTML color scheme patch
From:       "=?ISO-8859-1?Q?Percy_Camilo_Trive=F1o_Aucahuasi?=" <orgyforever () gmail ! com>
Date:       2008-06-27 3:35:09
Message-ID: 579229230806262035h11c7aa53o61dbfcc4e15ea1d4 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi, I built khtml and konqueror (this last without need it :)), the patch
break completly the configuration of the styleshet, all the settings doesn't
work becouse the background color always is white and the foreground color
is black. Also konqueror is crashing on exit.

I'm attaching the bugtrace (btrace.txt), I don't know how works khtml to
paint the pages but certainly it can't show all the pages when the
background (and foreground) isn't the default. Perhaps the patch should use
KStatefulBrush and KColorScheme::* instead QPalette.

Percy



On Thu, Jun 26, 2008 at 8:23 PM, Conor W Sullivan <premiersullivan@gmail.com>
wrote:

> Sorry, I meant to send this from a different account
>
> Hi, where is the best place to discuss khtml issues?  The following is a
> patch
> to kdelibs/khtml/khtml_part.cpp which simply sets the part's color scheme
> as
> being a generic black-on-white color scheme.  This is because khtml often
> works with webpages that conflict severly with dark color schemes.  I can
> add a
> system settings option to disable this is you like.
>
> To see the need for the patch, switch to a dark color scheme and navigate
> with
> konqueror to a site like this:
>
> http://www.usenix.org/event/usenix04/tech/freenix/full_papers/faure/faure_html/node5.html
> The page is difficult to read because the background is a dark gray.  We
> can't
> change how sites are written, but we can change how khtml handles it.
>
> My patch fixes sites like this by simply settings the QPalette of the site
> to a
> generic color scheme.  After applying my patch, the site renders well.
>
>  However, it seems not to work on oxygen-rendered widgets.   Somewhere in
> khtml code, I think that the QPalette is being overridden.  Look at sites
> like
> www.facebook.com or www.google.com and see how the text boxes, buttons,
> etc
> are still light on dark even with my patch.  On some sites , this can be
> very
> problematic.  Any suggestions on how to make this patch better is
> appreciated.
>
>
>
>
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>

[Attachment #5 (text/html)]

Hi, I built khtml and konqueror (this last without need it :)), the patch break \
completly the configuration of the styleshet, all the settings doesn&#39;t work \
becouse the background color always is white and the foreground color is black. Also \
konqueror is crashing on exit.<br> <br>I&#39;m attaching the bugtrace (btrace.txt), I \
don&#39;t know how works khtml to paint the pages but certainly it can&#39;t show all \
the pages when the background (and foreground) isn&#39;t the default. Perhaps the \
patch should use KStatefulBrush and KColorScheme::* instead QPalette.<br> \
<br>Percy<br><br><br><br><div class="gmail_quote">On Thu, Jun 26, 2008 at 8:23 PM, \
Conor W Sullivan &lt;<a href="mailto:premiersullivan@gmail.com" \
target="_blank">premiersullivan@gmail.com</a>&gt; wrote:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">

Sorry, I meant to send this from a different account<br>
<br>
Hi, where is the best place to discuss khtml issues? &nbsp;The following is a \
patch<br> to kdelibs/khtml/khtml_part.cpp which simply sets the part&#39;s color \
scheme as<br> being a generic black-on-white color scheme. &nbsp;This is because \
khtml often<br> works with webpages that conflict severly with dark color schemes. \
&nbsp;I can add a<br> system settings option to disable this is you like.<br>
<br>
To see the need for the patch, switch to a dark color scheme and navigate with<br>
konqueror to a site like this:<br>
<a href="http://www.usenix.org/event/usenix04/tech/freenix/full_papers/faure/faure_html/node5.html" \
target="_blank">http://www.usenix.org/event/usenix04/tech/freenix/full_papers/faure/faure_html/node5.html</a><br>
 The page is difficult to read because the background is a dark gray. &nbsp;We \
can&#39;t<br> change how sites are written, but we can change how khtml handles \
it.<br> <br>
My patch fixes sites like this by simply settings the QPalette of the site to a<br>
generic color scheme. &nbsp;After applying my patch, the site renders well.<br>
<br>
&nbsp;However, it seems not to work on oxygen-rendered widgets. &nbsp; Somewhere \
in<br> khtml code, I think that the QPalette is being overridden. &nbsp;Look at sites \
like<br> <a href="http://www.facebook.com" target="_blank">www.facebook.com</a> or <a \
href="http://www.google.com" target="_blank">www.google.com</a> and see how the text \
boxes, buttons, etc<br> are still light on dark even with my patch. &nbsp;On some \
sites , this can be very<br> problematic. &nbsp;Any suggestions on how to make this \
patch better is appreciated.<br> <br>
<br>
<br>
<br>
<br><br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> <br></blockquote></div><br>


["btrace.kcrash" (application/octet-stream)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]