[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: fsync() madness
From:       Sami Liedes <sliedes () cc ! hut ! fi>
Date:       2008-04-21 15:15:51
Message-ID: 20080421151551.GJ8760 () nun4 ! kyla ! fi
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Mon, Apr 21, 2008 at 02:11:40PM +0200, Lubos Lunak wrote:
> On Sunday 20 of April 2008, Sami Liedes wrote:
> > I had missed that post. Still, no analysis of the performance hit
> > there, and I think the attitude of "no data loss at all allowed at any
> > power loss, implement at any cost to performance" is misguided.
>=20
>  Tell that to XFS developers and their users. Anyway, where's your patch?

The patch is simple and not very fine grained, but effective and
shouldn't break anything unless a power loss happens. Attached.

	Sami

["nofsync.patch" (text/x-diff)]

--- kdelibs-3.5.9.dfsg.1.orig/kdecore/ktempfile.cpp	2005-10-10 18:06:02.000000000 \
                +0300
+++ kdelibs-3.5.9.dfsg.1/kdecore/ktempfile.cpp	2008-04-20 05:18:56.000000000 +0300
@@ -233,7 +233,8 @@
 
    if (mFd >= 0)
    {
-      result = FDATASYNC(mFd);
+      //result = FDATASYNC(mFd);
+      result = 0; 
       if (result)
       {
          kdWarning() << "KTempFile: Error trying to sync " << mTmpName << ": " << \
strerror(errno) << endl;


["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]