[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Kcoloredit maintenance
From:       "=?ISO-8859-1?Q?Percy_Camilo_Trive=F1o_Aucahuasi?=" <orgyforever () gmail ! com>
Date:       2008-01-05 17:39:09
Message-ID: 579229230801050939m5adbcec0pa10ca48b7e4433b7 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello Artur, thanks for the tips. Recently I finished refactoring the
"Color" class. In short, i added 2 members and their access methods:

* "QString mComment"
* "QColor mColor"

I have removed these methods and members:

* Everything on "component" (Because QColor offers that funcionality)
* "Color::equals" (Replaced with:
"bool operator == (const Color &color) const")

Until here, i have changed all the related code with "Color", i think the
idea of this class is like a "data transfer object" and the class "Palette"
is more like a "data acces object", right?

This is the proper way? Or am forgetting something. Any advice or
suggestions help me a lot ;-).

2007/12/26, Artur Rataj <arturrataj@gmail.com>:
>
> Hello Percy.
>
> On Dec 24, 2007 4:20 PM, Percy Camilo Triveņo Aucahuasi
> <orgyforever@gmail.com> wrote:
> > Hello Artur, is nice to work in this project. About the bug, I was
> seeing
> > the code and i wondering if is a good idea that the color class (color.h
> )
> > could contain the comment about the color.
>
> You can, for example, refactor Color to Entry, move color definition from
> Entry
> to its new subclass Color, and also add another Entry subclass named
> Comment,
> not containing any fields as both color name and comment contents may
> be simply Entry names.
>
> Best regards,
> Artur
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>

[Attachment #5 (text/html)]

Hello Artur, thanks for the tips. Recently I finished refactoring the \
&quot;Color&quot; class. In short, i added 2 members and their access \
methods:<br><br>* &quot;QString mComment&quot;<br>* &quot;QColor mColor&quot;<br><br> \
I have removed these methods and members:<br><br>* Everything on \
&quot;component&quot; (Because QColor offers that funcionality)<br>* \
&quot;Color::equals&quot; (Replaced with: <br>&quot;bool operator == (const Color \
&amp;color) const&quot;) <br><br>Until here, i have changed all the related code with \
&quot;Color&quot;, i think the idea of this class is like a &quot;data transfer \
object&quot; and the class &quot;Palette&quot; is more like a &quot;data acces \
object&quot;, right? <br><br>This is the proper way? Or am forgetting something. Any \
advice or suggestions help me a lot ;-).<br><br><div><span \
class="gmail_quote">2007/12/26, Artur Rataj &lt;<a \
href="mailto:arturrataj@gmail.com">arturrataj@gmail.com </a>&gt;:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">Hello Percy.<br><br>On Dec 24, 2007 4:20 PM, Percy \
Camilo Triveņo Aucahuasi<br> &lt;<a \
href="mailto:orgyforever@gmail.com">orgyforever@gmail.com</a>&gt; wrote:<br>&gt; \
Hello Artur, is nice to work in this project. About the bug, I was seeing<br>&gt; the \
code and i wondering if is a good idea that the color class ( color.h)<br>&gt; could \
contain the comment about the color.<br><br>You can, for example, refactor Color to \
Entry, move color definition from Entry<br>to its new subclass Color, and also add \
another Entry subclass named Comment, <br>not containing any fields as both color \
name and comment contents may<br>be simply Entry names.<br><br>Best \
regards,<br>Artur<br><br>&gt;&gt; Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub">http://mail.kde.org/mailman/listinfo/kde-devel#unsub
 </a> to unsubscribe &lt;&lt;<br></blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]