[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Icon patch for KNotify configuration widget
From:       Bernhard Beschow <bbeschow () cs ! tu-berlin ! de>
Date:       2007-12-02 20:52:02
Message-ID: 200712022152.02608.bbeschow () cs ! tu-berlin ! de
[Download RAW message or body]

Am Freitag 30 November 2007 schrieb Aaron J. Seigo:
> On Thursday 29 November 2007, Bernhard Beschow wrote:
> > Am Donnerstag 29 November 2007 schrieb Aaron J. Seigo:
> both patches look good to me; thanks for working on them. do you have an
> svn account or do you need someone to commit these for you? (if so, i can
> do that tonight for you... just le me know ... )

No, I don't have a SVN account yet. Would be great to have one, though. I'll 
be going to apply for one. In the meantime I'd appreciate if you'd commit 
both patches for me. Thanks!

> btw, other issues that leap out at me with that dialog:
> 
> - the icons in the list should probably be aligned into colums within that
> one column, so they vertically align with like types. this will probably
> improve the look quite a bit. this means leaving blank spaces for options
> not there
> 
> - what might be nice and useful is to be able to change state by click on
> the icons in the list. innactive (unchecked) items could be represented by
> innactive (e.g. greyed out) icons.

I could take care of that. I guess it's best to leave the comboboxes and let 
the buttons in the list be just an alternative way for (de-)activating a 
notification type. 

Actually, I was playing a bit to pluginify knotify since it would be great to 
easily add 3rd-party plugins. For instance, I've written a Thinklight plugin 
which could be loaded on Thinkpads. But that might be a topic for KDE 4.1.

Then I was asking myself how the plugin settings for each notification type 
could be presented to the user, depending on the loaded plugins. Maybe with a 
list of checkable QGroupBoxes. However, a QGroupBox cannot be assigned an 
icon. That's bad. Also, since the Oxygen style centers the captions (and 
hence the checkboxes) in the groupbox, the result would be very unusable. So 
for this idea to work both the QCheckBox class and the Oxygen style need to 
be adapted.

For a visual impression here are some Mockups:
Oxygen without flat QGroupBoxes: [http://www.250kb.de/u/071202/p/75f042ca.png]
Oxygen with flat QGroupBoxes: [http://www.250kb.de/u/071202/p/958da11e.png].
Plastique with flat QGroupBoxes: 
[http://www.250kb.de/u/071202/p/e110d77c.png]. 

Best whishes,
Bernhard
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]