[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Icon patch for KNotify configuration widget
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-11-30 1:15:56
Message-ID: 200711291815.57294.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 29 November 2007, Bernhard Beschow wrote:
> Am Donnerstag 29 November 2007 schrieb Aaron J. Seigo:
> > i usually recommend sending a screenshot with such visual changes. i'd do
> > one up for you right now, but i'm eyeballs deep in plasma atm.
>
> Alright, I've done a screenshot myself. But thanks anyway, Aaron! In the

thanks =) that clear things up immediately.

> I don't know, however, what is causing the issue with the texts of the
> check boxes not being completely shown. This bug shows up in the Oxygen and
> Plastik styles, but not in the Plastique and Windows styles. Maybe it's a
> bug in the styles or in QCheckbox.

yes, that's a bug in the styles. not many checkboxes have icons, so it's an 
easy thing to miss =) i'll raise it with the oxy developers, or maybe even 
try my hand at a patch.

> Anyway, what you can also see is that the icons in the list are randomly
> not in the same order. See the Beep and the Catatrophe lines for example.

both patches look good to me; thanks for working on them. do you have an svn 
account or do you need someone to commit these for you? (if so, i can do that 
tonight for you... just le me know ... )

btw, other issues that leap out at me with that dialog:

- the icons in the list should probably be aligned into colums within that one 
column, so they vertically align with like types. this will probably improve 
the look quite a bit. this means leaving blank spaces for options not there

- what might be nice and useful is to be able to change state by click on the 
icons in the list. innactive (unchecked) items could be represented by 
innactive (e.g. greyed out) icons.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]