[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: feedback; bug reports
From:       James Richard Tyrer <tyrerj () acm ! org>
Date:       2007-11-15 2:06:17
Message-ID: 473BA999.2070207 () acm ! org
[Download RAW message or body]

James Richard Tyrer wrote:

> Ok, I will submit a patch for this specific instance,

I appear to have confused this with another thread and the issue of 
having the name of the default icon theme ("oxygen") in the code.  This 
thread is about the fact that the names: filemanagement & webbrowsing 
were in the actual code, rather than being in configuration files.

Having them in actual code is something which I was taught was a poor 
programing practice -- that such things should be in configuration files 
and the code should contain the keys to access them in configuration 
files.  I hope that that sounds reasonable.

IAC, with KDE3, I did try to patch this and found that the code had 
become convoluted -- as tends to happen with the passage of time -- and 
it would be very difficult to fix this with a patch.  Which is why they 
shouldn't be included in the code -- right?

However, we have a different situation now with KDE4 since the code 
should be new and not convoluted by the passage of time.  So, I will 
look at the code.  This will probably not be as easy to fix as the 
default icon theme name issue (which I think that I have already fixed 
on my system).

-- 
JRT
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]