[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] ksysguard : support wireless signal sensors
From:       Bertrand Haut <bertrand.haut () brutele ! be>
Date:       2007-01-27 10:51:42
Message-ID: 200701271151.45803.bertrand.haut () brutele ! be
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 26 January 2007 23:01:28 Adriaan de Groot wrote:
> On Friday 26 January 2007 19:20, Bertrand Haut wrote:
> > The patch modify netdev.c. If an interface is listed in
> > /proc/net/wireless, the following sensors are added:
>
> My first question is: how hard-coded is all of this? Have you prepared your
> code for enough #ifdeffing or plugins to support
> things-which-are-not-linux?
>
Short answer : this patch is Linux-specific.

Long answer : this is a patch for ksysguardd, the backend of ksysguard. This 
backend is coded in C, not in C++ ¹, and consists of two parts. The first is 
OS-independent and the second is OS-dependent (i.e. a directory for Linux, 
Irix, OpenBSD,...). This patch modifies the file ksysguardd/Linux/netdev.c 
which was already only usable for Linux.

Maybe it is possible to share more code between the ksysguardd/OS directories 
but that will ask a very important work.


¹ : what I don't understand is why is this written in C ? The reason stated is
"This client/server design was chosen, because on some operating
systems the back-end needs elevated permissions. Since C++ programs
should NEVER have setgid/setuid permissions, a plain C back-end was
needed."
Why a C++ program can not have a setgid/setuid permissions ?


-- 
Bertrand Haut
ICQ:48978874

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]