[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdelibs4: Explicit creators
From:       "Will Entriken" <kde.org () phor ! net>
Date:       2006-09-13 19:52:30
Message-ID: c0be00e90609131252r85d6cb5i287055e6779dfe56 () mail ! gmail ! com
[Download RAW message or body]

I don't have the tools to compile:

 kdevelop/
 kdewebdev/
 kdepim/

Would somone who is running any of these please apply this patch to
kdelibs and then fix the few errors you get? A typical fix will look
like this:

-  setButtonGuiItem( User1, i18n("Edit") );
+  setButtonGuiItem( User1, KGuiItem(i18n("Edit")) );

Then the whole trunk/ will be ready and we can commit that patch.

Thanks,
  Will Entriken

Index: kdeui/kguiitem.h
===================================================================
--- kdeui/kguiitem.h    (revision 583538)
+++ kdeui/kguiitem.h    (working copy)
@@ -40,14 +40,14 @@
 public:
     KGuiItem();

-    // ### This should probably be explicit in KDE 4; it's easy to get
-    // subtle bugs otherwise - the icon name, tooltip and whatsthis text
-    // get changed behind your back if you do 'setButtonFoo( "Bar" );'
-    // It gives the wrong impression that you just change the text.
-    KGuiItem( const QString &text,
-              const QString &iconName  = QString(),
-              const QString &toolTip   = QString(),
-              const QString &whatsThis = QString() );
+    // This is explicit because it's easy to get subtle bugs otherwise. The
+    // icon name, tooltip and whatsthis text get changed behind your back if
+    // you do 'setButtonFoo( "Bar" );' It gives the wrong impression that you
+    // just change the text.
+    explicit KGuiItem( const QString &text,
+                       const QString &iconName  = QString(),
+                       const QString &toolTip   = QString(),
+                       const QString &whatsThis = QString() );

     KGuiItem( const QString &text, const QIcon &iconSet,
               const QString &toolTip   = QString(),
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]