[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdeutils and gcc4.1
From:       me <kev.gilbert () cdu ! edu ! au>
Date:       2005-09-30 5:13:34
Message-ID: 200509301431.37772.kev.gilbert () cdu ! edu ! au
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Fri September 30 2005 14:21, Adriaan de Groot wrote:
> On Friday 30 September 2005 06:08, me wrote:
> > === START /kmilo/asus/asus.h ====
> > @@ -28,6 +28,10 @@
> >
> >  #include "monitor.h"
> >
> > +using namespace KMilo;
> > +
> > +namespace KMilo {
>
> Seems reasonable so far.
>
> > +#ifdef Q_OS_FREEBSD
> > +               int brightness_mib[4];
> > +               int backlight_mib[4];
> > +               int video_mib[4];
> > +#endif
>
> That is clearly _not_ a gcc 4.1 compilation fix -- looks like you're
> dragging in patches from elsewhere by accident. Although I'm all for
> merging FBSD things upstream.
>
> > +       unsigned int wireless_toggle;     // wireless lan toggle
> > +       unsigned int bluetooth_toggle;    // bluetooth toggle
>
> Those look like they should be bools instead (unless they are used in the
> sysctl(8) interface, which requires ints AFAIK).

The 'diff' was generated by comparing 3.4.2 and 3.5 beta-1 where the FREEBSD 
patches are already included. I should have diff'd between a "clean" copy of 
3.5 beta-1 and my version.

Kevin

[Attachment #5 (application/pgp-signature)]

 =

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscrib=
e <<


[prev in list] [next in list] [prev in thread] [next in thread]