[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdeutils and gcc4.1
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-09-30 4:51:23
Message-ID: 200509300651.23911.groot () kde ! org
[Download RAW message or body]

On Friday 30 September 2005 06:08, me wrote:
> === START /kmilo/asus/asus.h ====
> @@ -28,6 +28,10 @@
>
>  #include "monitor.h"
>
> +using namespace KMilo;
> +
> +namespace KMilo {

Seems reasonable so far.

> +#ifdef Q_OS_FREEBSD
> +               int brightness_mib[4];
> +               int backlight_mib[4];
> +               int video_mib[4];
> +#endif

That is clearly _not_ a gcc 4.1 compilation fix -- looks like you're dragging 
in patches from elsewhere by accident. Although I'm all for merging FBSD 
things upstream.

> +       unsigned int wireless_toggle;     // wireless lan toggle
> +       unsigned int bluetooth_toggle;    // bluetooth toggle

Those look like they should be bools instead (unless they are used in the 
sysctl(8) interface, which requires ints AFAIK).

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]