[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KDE 3.4.2 Schedule
From:       James Richard Tyrer <tyrerj () acm ! org>
Date:       2005-06-27 17:29:27
Message-ID: 42C03777.8050801 () acm ! org
[Download RAW message or body]

Stephan Kulow wrote:
> Am Samstag 25 Juni 2005 21:09 schrieb James Richard Tyrer:
> 
>>Stephan Binner wrote:
>>
>>>Hello,
>>>
>>>the KDE 3.4.2 release is scheduled: tagging will happen on 20th July 2005 so 
>>>the last day for translations and bugfixes will be Tuesday, 19th July 2005.
>>
>>Would someone please take a look at this bug:
>>
>>http://bugs.kde.org/show_bug.cgi?id=104114
>>
>>and determine if the patch:
>>
>>	http://bugs.kde.org/attachment.cgi?id=10692&action=view
>>
>>and the new icons:
>>
>>	http://bugs.kde.org/attachment.cgi?id=11262&action=view
>>
>>will fix the problem and please commit them.
>>
>>Note that it is necessary to apply the patch before changing the icons. 
>>    It appears that someone tried to fix the problem by duplicating the 
>>icons, but this was only done for CrystalSVG style.  The real answer is 
>>to change the code and undo the change to the icons.
>>
> 
> If there is no legal bound "next" icon, then we have other places that are 
> broken. E.g. one in kstdaction.cpp for QApplication::reverseLayout - I'm
> _very_ unsure about this problem and would prefer a trunk only change.

We currently have the icons "next" & "previous".  The problem is that in 
CrystalSVG that they are the same as: "forward" & "back".  They are 
different in the other icon themes being shipped with KDE and they are 
different in the new CrystalClear theme.

It appears that there are other places where the change might need to be 
made.  Lines 83 & 84 of kstdaction.cpp need to be changed as well.

However grepping kdelibs/kdeui:

[root@localhost kdeui]# grep -R \"next\" *
kstdaction.cpp:                 if (id == Prior) iconName = "next";
kstdaction_p.h: { FindNext,      KStdAccel::FindNext, "edit_find_next", 
I18N_NOOP("Find &Next"), 0, "next" },
kstdaction_p.h: { Next,          KStdAccel::Next, "go_next", 
I18N_NOOP("&Next Page"), 0, "next" },

[root@localhost kdeui]# grep -R \"previous\" *
kstdaction.cpp:                 if (id == Next ) iconName = "previous";
kstdaction_p.h: { FindPrev,      KStdAccel::FindPrev, "edit_find_last", 
I18N_NOOP("Find Pre&vious"), 0, "previous" },
kstdaction_p.h: { Prior,         KStdAccel::Prior, "go_previous", 
I18N_NOOP("&Previous Page"), 0, "previous" },
ktabwidget.moc: { "previous", &static_QUType_bool, 0, QUParameter::In }

doesn't turn up anything other than your example that needs to be 
changed.  I think that KStdAccel::FindNext & KStdAccel::FindPrev should 
use the icons "next" & "previous" unless we need (other) new icons for them.

I will revise the patch to make the changes to kstdaction.cpp.

Thanks for your help.

-- 
JRT
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]