[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Endless modprobe calls logged in KDE 3.4
From:       Kévin_Ottens <ervin () ipsquad ! net>
Date:       2005-02-09 9:24:41
Message-ID: 200502091024.42423.ervin () ipsquad ! net
[Download RAW message or body]

Le Mardi 8 Février 2005 12:13, David Faure a écrit :
> Possibly. What I found out is that this patch/hack seems to solve the
> problem.
>
> --- mediamanager.cpp    29 Dec 2004 18:37:53 -0000      1.11
> +++ mediamanager.cpp    7 Feb 2005 21:34:16 -0000
> @@ -19,6 +19,7 @@
>  #include "mediamanager.h"
>
>  #include <config.h>
> +#include <qtimer.h>
>
>  #include <kdebug.h>
>  #include <kglobal.h>
> @@ -49,7 +50,7 @@ MediaManager::MediaManager(const QCStrin
>                  SLOT(slotMediumChanged(const QString&, const QString&)) );
>
>         m_backends.setAutoDelete(true);
> -       loadBackends();
> +       QTimer::singleShot( 10, this, SLOT( loadBackends() ) );
>  }
>
>  void MediaManager::loadBackends()

That's clearly a hack... But if it's enough, why not.
Should I commit it or you'll do it yourself?

> Hmm. What's strange is that in my recent tests mediamanager isn't loaded on
> startup anymore, only when I go to media:/ in konq; but it used to be
> loaded at startup, I guess due to kdesktop... although, well, I have
> disabled device icons there, so I don't know why it used to load
> mediamanager on startup. OK - I hope this doesn't matter and that the above
> is a real fix.

Maybe try to reactivate the device icons on kdesktop before committing... 
maybe that's related.

> But I would like to confirm my suspicion:
> if I "dcop kded kded unloadModule mediamanager" then the blinking stops!
> So it's for sure due to LinuxCDPolling.

Don't forget I have a KDirWatch on fstab and mtab... It should use fam if it's 
available (IIRC). If it's not the case that's maybe why you're experiencing 
this blinking.
The LinuxCDPolling thread doesn't access the hard drives... really.

> This problem is of course unrelated to the one on top of this mail (the
> long startup delay).

Indeed.

> Personally I can live with HAL being required for such neat features, if
> the without-HAL solution means a nasty polling. But I understand that
> almost nobody has HAL available yet...

You're right, even if HAL seems to spread quickly... So maybe I could (as a 
last modification) use your proposed hack and disable the linux cd polling by 
default, it could be activated using a special kconfig key somewhere (not 
sure where yet), but I won't provide its kcontrol counterpart since it will 
be more a choice in the hands of the distributor to enable it or not.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]