[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: dirtree_module and URLs with passwords
From:       David Faure <faure () kde ! org>
Date:       2004-10-23 8:25:22
Message-ID: 200410231025.23891.faure () kde ! org
[Download RAW message or body]

On Friday 22 October 2004 18:26, Jakub Stachowski wrote:
> Hello,
> 
> dirtree_module from kdebase/konqueror/sidebar/trees/dirtree_module currently 
> breaks on URLs with passwords. For example redirection from 
> dnssd://_ftp._tcp/some service to ftp://user:pass@host/ results in "Cannot 
> find parent item URL in the tree. Internal error.". This is because all URLs 
> are inserted into dictionary with passwords, but searched for (in 
> slotNewItems) without - so keys don't match. Password is stripped at 
> dirtree_module.cpp:393 , just before dictionary lookup. Is there any reason 
> for doing this? If not, can I remove this line?

cvs annotate has the answer to your question...

1.9          (faure    06-Nov-01):     dir.setPass( QString::null );

revision 1.9
date: 2001/11/06 02:43:41;  author: faure;  state: Exp;  lines: +1 -0
Fixed #34557 (ftp urls with pass in the url -> crash)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]