[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Bug 88964 - Highlighting of files in Detailed List View
From:       Richard Smith <kde () metafoo ! co ! uk>
Date:       2004-10-16 0:57:24
Message-ID: 200410160202.57582.kde () metafoo ! co ! uk
[Download RAW message or body]

Hi,

On Saturday 16 October 2004 00:19, Andre Moreira Magalhaes wrote:
>  1) Make the draw of the focus rect be responsibility of the function
> paintCell. All the apps that reimplement paintCell to really draw the
> item (this is not all the cases), should draw the focus rect if
> appropriate. I believe that there is not a lot of apps that need this,
> and the change is simple.
[...]
> I believe that the first solution is more appropriate since it does not
> break binary compatibility

Technically, it doesn't. Practically, it means that applications written 
without consideration for these changes in Qt won't work properly, and that 
applications written with consideration for these changes won't work without 
them. Hence it breaks backwards compatibility on two counts.

Also, what should Kopete do? The QListViewItems in its contact list widget are 
nonrectangular. width() is overridden to return the full width of the item, 
otherwise the items don't get mouse events everywhere they want them. Clicks 
in different places do different things anyway, conflicting with an 
assumption of bug 88964. This seems to be the exception to just about every 
rule.
-- 
Thanks,
Richard
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]