[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: ThumbCreator
From:       Michael Pyne <pynm0001 () comcast ! net>
Date:       2004-03-29 21:32:31
Message-ID: 200403291632.37107.pynm0001 () comcast ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 29 March 2004 18:19, Bosselut Cyril wrote:
> i've modified my Makefile.am so now the lib is in /usr/lib/kde3 but i get
> the same error
> i've attached my files, so i you see something ;)

I only see two things:

Makefile.am:
libmp3thumbnail_la_LDFLAGS = -module $(all_libraries) ...

This part will expand into something like -module lib1.so lib2.so ... libn.so 
(at least, I'm pretty sure it will :-) ).  Is this intentional?  A 
kfile-plugin I have handy has something like
kfile_rpm_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN) instead.

mp3thumbcreator.cpp:
		if(tags->haveCover){
			img = (tags->cover).smoothScale(height, width, QImage::ScaleMin);
			return true;
		}
		else{
			return false;
		}
	}
	else{
		return false;
	}

This part can be replaced with:
		if(tags->haveCover){
			img = (tags->cover).smoothScale(height, width, QImage::ScaleMin);
			return true;
		}
	}

	return false;

, which is much easier to read.  Also, why have the #include "../tags.h" part?  
You can simply add in the appropriate path in the Makefile.am.

Regards,
 - Michael Pyne
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAaJXzqjQYp5Omm0oRAu+sAKCRq6oOQBFefGhrbodswDfVoCLWVQCguUMl
0A9tcoyrHPWjAcv3RjvKI6Y=
=hzof
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]