[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] KStringHandler::obscure
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2003-11-26 0:27:21
[Download RAW message or body]

On Tue, Nov 25, 2003 at 07:12:28PM +0100, Szombathelyi György wrote:
> --- kdecore/kstringhandler.cpp.old	2003-11-23 20:34:56.000000000 +0100
> +++ kdecore/kstringhandler.cpp	2003-11-25 19:00:57.000000000 +0100
> @@ -646,9 +646,8 @@
>  {
>    QString result;
>    for ( uint i = 0; i < str.length(); ++i )
> -    result += ( str.unicode()[ i ].unicode() < 0x20 ) ? str.unicode()[ i ] :
> -        QChar( 0x1001F - str.unicode()[ i ] );
> -
> +    result += ( str[ i ].unicode() < 0x20 ) ? str[ i ] :
> +        QChar( 0x1001F - str[ i ].unicode() );
>    return result;
>  }
>  
this is slower: str[i] does range checking.
as for waldo's comment - maybe that's actually the reason for the
problem. use QChar( 0x1001f - str.unicode()[ i ].unicode() ).

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]