[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [patch] request for review - apidox for kdelibs/kdeui (long)
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2003-09-07 11:17:38
[Download RAW message or body]

I do not think that adding #if KDE_NO_COMPACT is allowed.

KDE_NO_COMPACT is only for major version KDE 2, KDE 3, future KDE 4. Inside a 
major version (KDE 3.0, 3.1, 3.2..), it should *not* be added. (Someone has 
already broken KOffice this way, so please do not start that again!)

Have a nice day!

On Sunday 07 September 2003 08:46, Brad Hards wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> G'day,
>
> As part of the KDE developers book, I'm thinking that we should clean up
> the API reference documentation. I'm not sure about a lot of things, so I'm
> working this in stages. Stage 1 starts here.
>
> The changes below are from kdelibs/kdeui. They are intended to clean up the
> "make apidox" output in preparation for subsequent changes and review. The
> idea is that "make apidox" should build cleanly, so it is easier to find
> any regression, and that is what the diff below does.
>
> There are four sorts of changes:
> 1. #ifdef in some .cpp files to make the implementation match the interface
> 2. Fixes for some missing entries
> 3. Placeholders for the rest of the missing entries
> 4. Minor fixups / reformatting that occurred in the process of the first
> three.
>
> I'm mostly worried about the first set of changes, because I don't fully
> understand the intent of the #ifndef KDE_NO_COMPAT macro, and I worry about
> binary incompatible changes.
>
> I'm not planning on committing this for at least a week, to provide a bit
> of time for those recovering from N7Y, but feedback soon would be good,
> because I'm going to be away (no email after 2200 UTC monday night), and
> I'd like to fix up any issues, and build on this round of changes.
>
> Brad
>
(...)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]