[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Patch] #48264: added a Today button in kdatepicker
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2003-08-14 18:45:00
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 14 August 2003 18:30, André Somers wrote:
> >on challenge is that the items on the bottom are informational while the
> >arrows at the top are navigational... "Today" looks like a label, not
> >navigation, and that's only reinforced by the other two textual areas down
> >there.
> >
> >either the today nav should be moved up top (not exactly sure right now
> > how to do that and make it look nice), or it needs to be more obviously
> > not a label, IMHO
>
> I think that's a matter of widgetstyle. At my system, the week _does_ look
> like a button (and it is!), and so will the Today button in that case.
>
> André

Yes. If I look at KDE-3.1.2 with keramik, all the buttons do look like 
buttons.
See http://members.aon.at/m.koller/old-kdatepicker.png
As I did not install everything on my HEAD KDE setup, I assume I have another 
style used at the new screenshot.

It seems that there were more changes from 3.1.2 to 3.2, because in 3.2, the 
top-buttons are inside a KToolBar, which make them now less look like 
buttons.
Therefore also the  bootom-buttons (week, today) have set the autoraise 
feature like in the toolbar ... personally I think this is not a good style, 
a button should look like a button, not like a label, but I did not want to 
break that.

Regarding the "Today" buttontext, I modified the patch to use the "today.png" 
which is also used in korganizer.
Here are screenshots with the icon
1) with autoraise: 
http://members.aon.at/m.koller/kdatepicker-autoraise.png
2) without autoraise:
http://members.aon.at/m.koller/kdatepicker-noautoraise.png

Question regarding icons: What icons can I assume to be existing when a user 
did only install kdelibs ?
Are all icons in the pics/ subdirs ?
If so, I have to add the today icon to it.

Regarding the week-button: I think that a button which pops up a textfield to 
input a week number is a bad choice.
What do you think about changing this to a ComboBox ?
(Or was there a reason for a text input field regarding different calendar 
systems ?)

And for me it's also not clear, why the month selection works in a very 
uncommon way with a special popup. Why not using a Combobox here again?
Even the year selection could use a spinbox instead of a popup.


Comments?
- -- 
Best regards/Schöne Grüße

Martin

Public key at:
http://blackhole.pca.dfn.de:11371/pks/lookup?op=get&search=0x8DFB0F86
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/O9isHmdPoI37D4YRAgf2AJ465XsXTEWPxS9DPUuBr3Urg+FswACfXwH+
tnZClaN3li94AzARx64PSeM=
=0ntt
-----END PGP SIGNATURE-----

["patch" (application/octet-stream)]
["today.png" (image/png)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]