[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Tab switching on close....
From:       Matt Rogers <matt () matt ! rogers ! name>
Date:       2003-06-23 1:55:33
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 22 June 2003 08:42 pm, Gaston, Derek Ray (UMR-Student) wrote:
> Matt,
>
> Thanks for the heads up on the issues - I have found other issues as well
> (having to do with the indexing of the tabs - IT DOES WORK the way it is
> but I am not sure it is correct).
>
> About diffing against HEAD - I know, I mostly just wanted to start a
> discussion about it - and I had the 3.1.2 source on my hardrive already -
> and I didn't want to take the time to pull down kdecvs.
>
> Sorry about not posting this to kfm-devel - I didn't know it existed until
> someone pointed this out to me on IRC.
>
> Anyway - my question still stands - does anyone know if this has been dealt
> with yet?  I will probably pull down kde-cvs tonight and do some
> investigation for myself - but I really don't want to run over anyone
> else's toes....
>
> Derek
>

The smart people over at kfm-devel will be able to tell you this for sure. :) 
I don't know personally. 

>
> -----Original Message-----
> From:	Matt Rogers [mailto:matt@matt.rogers.name]
> Sent:	Sun 6/22/2003 7:24 PM
> To:	kde-devel@kde.org
> Cc:
> Subject:	Re: Tab switching on close....
>
> On Sunday 22 June 2003 07:02 pm, Gaston, Derek Ray (UMR-Student) wrote:
> > Not sure if this has already been addressed - but it is something that
> > has bothered me for a real long time...  Which tab gets switched to when
> > you close one in Konq.
> >
> > To the average user it looks almost random - sometimes it goes to the tab
> > on the left sometimes to the right. (In most other tab enabled programs
> > (such as mozilla) it always goes to the right).
> >
> > I dug in today to see if I could figure out why - and frankly I can't. 
> > But I was able to create a patch to fix it so that it always acts just
> > like mozilla.
> >
> > The patch is against kdebase-3.1.2.tar.bz2 and is for
> > kdebase-3.1.2/konqueror/konq_viewmgr.cc
> >
> > Here is the diff:
> >
> > 549a550,560
> >
> > >   else
> > >   {
> > >     int iTab = tabContainer->currentPageIndex();
> > >
> > >     if( iTab == tabContainer->count() )
> > >       iTab--;
> > >     else
> > >       iTab++;
> > >
> > >     tabContainer->setCurrentPage( iTab );
> > >   }
> >
> > What is there is pretty self explanatory.  It is surely not the best way
> > to do it - but it was the easiest (for me).  Most of the code came out of
> > activateNextTab().
> >
> > I would be interested in knowing if this topic has come up before -
> > and/or if there is already a fix for it in Current.
> >
> > Thanks,
> > Derek
>
> Two things that I see wrong with this patch right off the bat. The first is
> that you need to create your patches against CVS HEAD instead of 3.1.2. The
> second is that you should create your diffs (patches, whatever you wanna
> call them) using diff -u.
>
> Also, I would imagine (and i'm assuming that most konqueror developers
> would agree with me, but i could be wrong) that this patch might be better
> recieved at the kfm-devel mailing list since that's where konqueror
> development takes place.
>
> It's a good idea though. :)
>
> Matt
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<
> >>
> >>
> >>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+9l4XxrhqCS3lYYkRAoUTAJ9mLpwR7SvSlelCJgVhaOXQZ1t/qQCdGSCn
W9ULlr/oFbGDuF6VSYpqq3o=
=Aymy
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]