[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: in-place-editing patch for konqueror bookmarks
From:       "Aaron J. Seigo" <aseigo () olympusproject ! org>
Date:       2002-12-30 16:57:37
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 30 December 2002 02:36, Oelewapperke wrote:
> static ? wtf ?

to prevent having to know in advance which menu the context menu is over. 
otherwise you have to keep pointers around for every menu you create that may 
end up with a context menu, which would be very untidy and require a lot of 
bookkeeping. 

it also saves on memory. not every menu will use this feature, so it would be 
nice to keep the associated overhead down. since QPopupMenu doesn't allow one 
a way to see which item is currently highlighted after the initial activated 
signal has been sent (AFAIK, would love to be shown otherwise), we have to 
keep this information around for later usage. seeing as one can only have one 
context menu up at a time, this isn't a problem.

> and what if you are in a submenu (2 menu's will try to
> update this variable simultaneously) ?

no, just the menu the context menu is currently over. that's why in the 
evenFilter it checks the object for the event with this.

> or right click on an item in a right-click menu ?

that's actualy a bug in the porting from rmbMenu to KPopupMenu. in rmbMenu it 
returned a KPopupMenu for the context menu specifically because then you 
couldn't do this (and shouldn't, anyways... context menus on menus is bad 
enough ;)... in KPopupMenu it should return a QPopupMenu, elminating this 
problem.

btw, i tested this method extensively during the KDE 2.2 era and have since 
been using it in TOM, so it isn't like this is a concept piece that hasn't 
had any actual usage =)

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler"
    - Albert Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+EHsB1rcusafx20MRAl38AJ9JMEhZ2Z1L5L8pSIc9YDhbSjl6XwCfRH7e
Aj6s1TM0CF8PzXXBo8ZK+E4=
=t6rb
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]