[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: New OpenGL screensavers
From:       Klas Kalass <klas.kalass () gmx ! de>
Date:       2002-06-30 9:10:11
[Download RAW message or body]

Am Samstag, 29. Juni 2002 22:46 schrieb Neil Stevens:
> On Saturday June 29, 2002 12:41, Karl Robillard wrote:
> > Terence Welsh recently GPLed the source for his Windows screensavers.
> > His website is http://www.reallyslick.com/.
> >
> > So far I've ported Flux & Euphoria to KDE.
> > You can download the source at http://outguard.sf.net/arc/slick.tgz (but
> > only for a while).
> >
> > Please check them out for any problems.  Then lets get them into the
> > kdeartwork module.
>
> Look good to me, compiled fine, and look interesting.  I say put them in.
>
> :-)
>
> Though, trying to fix the Makefile exposed to me a problem - adding GL
> savers requires configure.in.in changes.  Attached is a patch to fix that
> for the future.  Any objections to me committing?
Hmm, that patch does not work for me. 
The problem seems to be that the qgl testprogram in configure.in.in is wrong. 
After fixing it, I get the following errors for configure with your patch:
/debian/home/kdecompiler/src/kdeartwork/configure: GL_XSAVERS: command not 
found
/debian/home/kdecompiler/src/kdeartwork/configure: GL_KSAVERS: command not 
found
/debian/home/kdecompiler/src/kdeartwork/configure: GL_DESKTOP_FILES: command 
not found

Without your patch (and with mine only) it works.
I attached my patch . Any objections to me commiting that one?

["screensaver-gl-fix-klas" (text/x-diff)]

Index: configure.in.in
===================================================================
RCS file: /cvs/kde/kdeartwork/kscreensaver/configure.in.in,v
retrieving revision 1.6
diff -u -3 -p -r1.6 configure.in.in
--- configure.in.in	2002/03/02 17:39:55	1.6
+++ configure.in.in	2002/06/30 08:58:26
@@ -14,10 +14,10 @@ AC_CACHE_VAL(ac_cv_kde_qt_has_opengl,
   LIBS="$LIBS $LIBQT $KDE_MT_LIBS"
 
   AC_TRY_LINK([
-  #include <qglwidget.h>
+  #include <qgl.h>
   ],
   [
-   QGLWidget = new QGLWidget(0);
+   QGLWidget *qglwidget = new QGLWidget(0);
   ],
   ac_cv_kde_qt_has_opengl=yes,
   ac_cv_kde_qt_has_opengl=no)

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]