[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] KArchiveDirectory::copyTo
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-06-26 6:57:26
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 26 June 2002 02:14, Gioele Barabucci wrote:
> OK, I've done it and tested a lot, but there is still one problem:
> IT IS SLOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOW
> it takes one/two minute to extract a 1 MB tar.gz file!!

With lots of small files, I suppose?
Yes, the problem is that .tar.gz is not random access (due to
the global gzip compression), but KArchiveFile::data() uses it 
as if it was random access ( device()->at( m_pos ) ).

This is the reason why KOffice uses ZIP and not .tar.gz anymore.
Can you try the same test with a ZIP file?

To fix the .tar.gz case, the solution is to copy the stuff in the same order
as it is in the archive.....Sort of an iterative loop (after sorting on m_pos)
instead of a recursive approach.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is coming very shortly...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9GWXW72KcVAmwbhARAuw4AJwM9yNz26EUjlWOLauyIwQ+M6zvBACghk5x
Etw/BzqkT+McQgMLlznhzOY=
=5+3l
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]