[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    RE: Removing unusable icons from URL bar
From:       Simon MacMullen <simon.macmullen () aspectgroup ! co ! uk>
Date:       2002-05-22 15:48:23
[Download RAW message or body]

From: Carsten Pfeiffer:
> On Wednesday 22 May 2002 15:15, Simon MacMullen wrote:
> > The attached patch prevents right clicking from selecting 
> an icon, and
> > allows deletion. OK to commit?
> 
> I agree with the idea, but there are a few problems with the patch:
> 
> The signature of slotSelected() cannot be changed, as it is 
> protected (and 
> therefore part of the API). You could add another method and 
> call this 
> slotSelected() from there tho.

Ah. OK. I will do this.
 
> I guess we also need some code to reset the current item 
> after the popup has finished.

I don't understand. As it is, the patch leaves the currently selected item
alone if you right-click on another item - why is this wrong?
 
> Additional one could add a check for 
> KProtocolInfo::suppoprtsListing() to see 
> if floppy:// and lan:// are available (hmm, I could swear I 
> added that 
> somewhen).

Of course, on my box the floppy:// is there, but doesn't work (no mtools)...

Thanks, Simon
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]