[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Removing unusable icons from URL bar
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2002-05-22 15:30:39
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Wednesday 22 May 2002 15:15, Simon MacMullen wrote:

Hi,

> The file dialog now has default entries for floppy and network, I see. The
> trouble is, if the floppy:// or lan:// ioslaves are not present or are not
> working, you can't remove these icons - right clicking to get the menu also
> selects them, which pops up an error message box and causes the menu to
> disappear again!
>
> The attached patch prevents right clicking from selecting an icon, and
> allows deletion. OK to commit?

I agree with the idea, but there are a few problems with the patch:

The signature of slotSelected() cannot be changed, as it is protected (and 
therefore part of the API). You could add another method and call this 
slotSelected() from there tho.

I guess we also need some code to reset the current item after the popup has 
finished.

Additional one could add a check for KProtocolInfo::suppoprtsListing() to see 
if floppy:// and lan:// are available (hmm, I could swear I added that 
somewhen).

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iQEVAwUBPOu5n6WgYMJuwmZtAQHBnwgAsKXCsCXuMFuyxZun3QsmX/T0J3Il9RWs
cVYycpxUJfuAPfNXBG2mScJZjJfAUP612FBMc9MCvil7/pO/h+xZsgFSno7JpfDu
y6MV/pk93judKZDxyZ5U1SVEbT/LyXNX9zHUOJnyCmlaeV5Pr0O50XI2wmC2lyOJ
/wDAOSFnZaAotOF1FEHp/VT1h1zBxG6sQdClUpVzowMwqu7H0ZNXXo8O/jXHzZDR
/tqBFhB1p9O5Ldet4lDo/IP8/ai33uXLZiftPv5KDAdwg2bVYv8x93X9GPUGMLGs
TcOLOO0GUfMhnP6lahG2WxVS8W0yhRNLNdPRoSXyFnJ8DybBQblqtg==
=zXZk
-----END PGP SIGNATURE-----

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]