[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Tabbed browsing popup shortcut
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-05-07 6:13:39
[Download RAW message or body]

On Tuesday 07 May 2002 03:42, Troels Tolstrup wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> > > Index: konq_mainwindow.cc
> > > ===================================================================
> > > RCS file: /home/kde/kdebase/konqueror/konq_mainwindow.cc,v
> > > retrieving revision 1.994
> > > diff -u -3 -p -r1.994 konq_mainwindow.cc
> > > --- konq_mainwindow.cc	30 Apr 2002 13:01:30 -0000	1.994
> > > +++ konq_mainwindow.cc	4 May 2002 23:15:26 -0000
> > > @@ -3413,7 +3413,7 @@ void KonqMainWindow::slotPopupMenu( KXML
> > >    QString name;
> > >    for ( int i = 0; i < 30; i++) {
> > >      name = pPopupMenu.text(pPopupMenu.idAt(i));
> > > -    if (name == i18n( "New Window" )) {
> > > +    if ( name.contains( i18n( "New Window" ) ) ) {
> >
> > This obviously breaks for any language != English.
> 
> Um, would you mind explaining that? It is very possible that i'm simply 
> stupid and fail to see the obvious, but i hope i'm not the only one :)

You're checking for a substring of a translatable string, which is a big no-no.
Hmm, what's this trying to do anyway? I see only one string containing
"New Window", I don't see how replacing == with contains changes anything.
Can you explain the patch?

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KDE, Making The Future of Computing Available Today


 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]