[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Abnormal behavior with Icons
From:       fenix <fenix () club-internet ! fr>
Date:       2002-04-15 20:10:11
[Download RAW message or body]

Le lun 15/04/2002 à 18:20, John Firebaugh a écrit :
> On Monday 15 April 2002 11:11, Torsten Rahn wrote:
> > > but in kdelibs/kdeui/khelpmenu.cpp at KHelpMenu::menu() line 159
> > > i have found:
> >
> > That's a bug as "go.png" isn't distributed together with kdelibs.
> >
> > > Kicker installs the "go" icon itself.
> >
> > Yes and it uses it instead of the "about_kde"-icon. It would be better if
> > it used the "good" icon instead (imagine that "about_kde" would look
> > different from "go" one day ... wouldn't be too consistent then, would it?)


[kde3@DarKBlue ~/kde/CVSHEAD]$ find . -name "*about_kde*"
./kdeartwork/IconThemes/slick/16x16/actions/about_kde.png
./kdeartwork/IconThemes/slick/32x32/actions/about_kde.png
./kdeartwork/IconThemes/slick/48x48/actions/about_kde.png
./kdelibs/pics/hicolor/hi16-action-about_kde.png
./kdelibs/pics/hicolor/hi22-action-about_kde.png
./kdelibs/pics/hicolor/hi32-action-about_kde.png
[kde3@DarKBlue ~/kde/CVSHEAD]$

[kde3@DarKBlue ~/kde/CVSHEAD/kdelibs]$ grep about_kde `find . -name
"*.cpp" -o -name "*.h" -o -name "*.ui"`
./kdeui/khelpmenu.cpp:    if (kapp->authorizeKAction("help_about_kde"))
./kdeui/kstdaction.cpp: { AboutKDE,      KStdAccel::AccelNone,
"help_about_kde", I18N_NOOP("About &KDE"), 0,"about_kde" },
[kde3@DarKBlue ~/kde/CVSHEAD/kdelibs]$ 

[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$ grep about_kde `find . -name
"*.cpp" -o -name "*.h" -o -name "*.ui"`
[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$

who use "about_kde" icon ???

> Actually, we probably want to separate the two: someone requested that the 
> icon used for the K-Menu be different than the "go" icon so that they could 
> be themed differently. So I changed kicker to also install "kmenu", which is 
> actually the same as "go" (I didn't know about "about_kde"). But the use 
> internally in kicker is not consistent -- sometimes "go"  is used by kicker 
> as the K-Menu icon and sometimes "kmenu". The "go" icon is also used as the 
> last-resort icon of an application in the taskbar.
>
> So, lets clean this up. IMO, kdelibs should install "about_kde" and a separate 
> "kgear" or "go" or whatever we decide to call it. KHelpMenu will use 
> "about_kde", stuff like the taskbar and minicli will use "kgear". Kicker will 
> install "kmenu" and always use that for the K-Menu. This provides maximum 
> flexibility for themes while ensuring that apps in kdebase use only icons 
> they install or icons in kdelibs.

after some test its seems only kicker use kmenu.png (as "start icon")
and "go" icon is used by KHelpMenu, kicker, kcontrol and minicli

[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$ grep \"kmenu\" `find . -name
"*.cpp" -o -name "*.h" -o -name "*.ui"`
./kicker/buttons/kbutton.cpp:    setIcon("kmenu");
[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$

[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$ grep \"go\" `find . -name "*.cpp"
-o -name "*.h" -o -name "*.ui"`
./kcontrol/style/menupreview.cpp:               QPixmap pix =
icl->loadIcon("go", KIcon::Desktop, KIcon::SizeLarge,
KIcon::ActiveState);
./kdesktop/minicli.cpp:    m_runIcon->setPixmap(DesktopIcon("go"));
./kdesktop/minicli.cpp:    m_runIcon->setPixmap( DesktopIcon("go") );
./kdesktop/minicli.cpp:        const QPixmap pixmap = DesktopIcon("go");
./kdesktop/minicli.cpp:            m_IconName =
QString::fromLatin1("go");
./khotkeys/khotkeys/khotkeys.cpp:                icon_name =
QString::fromLatin1( "go" );
./kicker/buttons/kbutton.h:    virtual QString defaultIcon() const {
return "go"; }
./kicker/taskmanager/taskmanager.cpp:   pixmap =
KGlobal::iconLoader()->loadIcon( "go",
./kicker/taskmanager/taskmanager.cpp:   pixmap =
KGlobal::iconLoader()->loadIcon( "go",
./kicker/taskmanager/taskmanager.cpp:   pixmap =
KGlobal::iconLoader()->loadIcon( "go",
./kicker/ui/addspecialbutton_mnu.cpp:    insertItem(SmallIconSet("go"),
i18n("K Menu"),
./kicker/ui/removespecialbutton_mnu.cpp:            insertItem(
SmallIconSet("go"), "K Menu", id );
[kde3@DarKBlue ~/kde/CVSHEAD/kdebase]$

but i don't understant how the same KHelpMenu code who load "go"-icon
display different version of this icon (the themed version and the
hicolor version) :(
How this can happen with the cache of iconloader ??

the same problem hapen with the configure.png icon (different kicker
menu/konqueror menu)

> later,
> John
>  
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
> 

FeniX


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]