[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Fwd: KDE 3.0RC3 Konqueror Javascript in online Banking - grave bug
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-03-31 20:40:35
[Download RAW message or body]

On Sunday 31 March 2002 05:09, Anthony M Farrell wrote:
> Attached is a file containing the source code for my online banking page. I 
> have removed account details and transactions but you can see the drop down 
> list boxes for the date selection. I hope you are able to use this to 
> identify why the date code does not work in Konqueror.

Yup, found and fixed.

khtml (jscript): KJS::HTMLSelectCollection::tryPut selectedIndex
wasn't implemented, only HTMLSelectElement.selectedIndex=N was.

Index: kjs_html.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/ecma/kjs_html.cpp,v
retrieving revision 1.171
diff -u -p -r1.171 kjs_html.cpp
--- kjs_html.cpp        2002/03/24 18:33:54     1.171
+++ kjs_html.cpp        2002/03/31 20:39:34
@@ -2829,8 +2829,12 @@ void KJS::HTMLSelectCollection::tryPut(E
 #ifdef KJS_VERBOSE
   kdDebug(6070) << "KJS::HTMLSelectCollection::tryPut " << propertyName.qstring() << endl;
 #endif
+  if ( propertyName == "selectedIndex" ) {
+    element.setSelectedIndex( value.toInteger( exec ) );
+    return;
+  }
   // resize ?
-  if (propertyName == "length") {
+  else if (propertyName == "length") {
     long newLen = value.toInteger(exec);
     long diff = element.length() - newLen;



-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]