[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] i18n KSirc
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2002-03-10 15:44:58
[Download RAW message or body]

On Sunday 10 March 2002 01:04, Simon Hausmann wrote:
> On Sun, Mar 10, 2002 at 12:40:22AM +0900, Toshitaka Fujioka wrote:
> > Hello,
> >
> > The attached patch is i18n patch for KSirc.
> > KSirc can read/write of non-latin1 character and connect to non-latin1
> > channel.
> >
> > You can set Options -> Set Encoding -> your encoding or RMB click on doc
> > icon in kicker -> Set Encoding -> your encoding.
> >
> > I added one i18n string (Set Encoding).
> > Please review.
>
> Interesting, Lars asked me for the same feature in Nuernberg, being
> able to select the encoding even per channel.
>
> I actually implemented it but the patch got a bit too big for my
> taste and I was planning on applying it after 3.0 -- I attached that
> patch.

I tested your patch. KSirc was able to read/write of Japanese.
Channel was not able to read/write of Japanese.

I think that the conversion from Unicode to const char* or
from const char* to Unicode had better implement it to
stdin_write(...) or stdout_read(...).

> Now your patch is even bigger -- btw, the QPopupMenu is leaked and
> encodingList() should be const :) -- and touches a lot more of
> ksirc's touchy code. The string handling has always been a bit
> whacky in the past.

Oh, I see. Thanks for advice.

> In my opinion it is too late to apply such changes to ksirc. It's
> definitely a good feature to include after 3.0 I think. (but that's
> just MHO, CC'ing the maintainer and malte)

Ok, I agree.

Thank you.
-- 
Toshitaka Fujioka
http://www.kde.org                The K Desktop Environment Project
                                                    fujioka@kde.org
http://www.kde.gr.jp               Japan KDE User's Group
                                                    toshitaka@kde.gr.jp

-- A journey of a thousand miles must begin with a single step.  Lao-zi --  
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]