[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] i18n KSirc
From:       Malte Starostik <malte () kde ! org>
Date:       2002-03-09 21:51:04
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag 09 März 2002 17:04:17 schrieb Simon Hausmann:
> On Sun, Mar 10, 2002 at 12:40:22AM +0900, Toshitaka Fujioka wrote:
> > Hello,
> >
> > The attached patch is i18n patch for KSirc.
> > KSirc can read/write of non-latin1 character and connect to non-latin1
> > channel.
> >
> > You can set Options -> Set Encoding -> your encoding or RMB click on doc
> > icon in kicker -> Set Encoding -> your encoding.
> >
> > I added one i18n string (Set Encoding).
> > Please review.
>
> Interesting, Lars asked me for the same feature in Nuernberg, being
> able to select the encoding even per channel.
>
> I actually implemented it but the patch got a bit too big for my
> taste and I was planning on applying it after 3.0 -- I attached that
> patch.
>
> Now your patch is even bigger -- btw, the QPopupMenu is leaked and
> encodingList() should be const :) -- and touches a lot more of
> ksirc's touchy code. The string handling has always been a bit
> whacky in the past.
>
> In my opinion it is too late to apply such changes to ksirc. It's
> definitely a good feature to include after 3.0 I think. (but that's
> just MHO, CC'ing the maintainer and malte)
Hi,

I didn't have time to look closely at either of your patches. As Stephan 
already said, it's a new feature, and therefore a candidate for post-3.0.
I strongly support the general idea but IMNSHO we should only use local8Bit() 
as a "compatibility" mode and default to utf-7 instead. With local8Bit(), 
multilingual conversations are not possible, with utf they are (can't use 
utf-8, IRC is too lousy for that :)
I'm not sure what other clients do, but any local encoding seems like a dead 
end to me. Also note that IRC is only partially 8-bit clean, so local8Bit() 
might cause problems with some chars in some locales anyway.

- -- 
Malte Starostik
PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A  27CD 5431 7745 D2F3 C787]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8ioPLVDF3RdLzx4cRAmR8AJ0UKw1tf6D4ZkWGG/4/CYg6Z61scwCgxowG
3YoiO+YaS3wiKqQb7TlLivg=
=n1bb
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]