[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    kdelibs-3.0beta2 on IRIX
From:       Jesse Barnes <jbarnes () sgi ! com>
Date:       2002-02-14 2:10:28
[Download RAW message or body]

Here's a list of issues and some patches for things I ran into on
IRIX.  Hopefully they'll be fixed for the final release.
kdelibs.patch has 'good' fixes, while kdelibs-compiler.patch has ugly,
kludgy workarounds for a bug in the MIPSPro 7.3 compilers.

Please Cc: me on any reply as I'm not subscribed to kde-devel.  I'm
open to any suggestions or additional testing people would like me to
do.

Thanks,
Jesse

genuine problems:

o configure.in: HAVE_IRIX not detected, and when it is '-laudio'
  doesn't get added to arts/flow/Makefile like it should, and '-lC'
  should be added to arts/flow/gsl/Makefile since it uses exception
  handling, but both are easily worked around
o configure.in: HAVE_X86_SSE erroneously detected <-- I don't know how
  to fix this one, so there's no fix in the patch
o kdeui/kmenubar.cpp:115, return in void function
o kio/kio/kfilemetainfo.h:258, 'Data' declared public: and protected:
o arts/flow/gsl/gslengine.h:91,97, const qualifiers shouldn't be
  there?  connected is modified in glsopmaster.c
o arts/flow/gsl/gsltests.c:534, arguments out of order
o arts/flow/gsl/gslglib.h should use HAVE_ALLOCA_H instead of
  GLIB_HAVE_ALLOCA_H or otherwise define it
o arts/flow/gsl/gslopnode.h doesn't define OP_DEBUG for non-gcc/DEC cc
  compilers
o khtml/dom/dom_element.cpp:154, return in void function
o khtml/khtml_run.cpp, same namespace bug as above

problems caused by a compiler bug:

* interfaces/ktexteditor/editor.moc triggers compiler bug in namespace 
  handling--workaround is to add 'using namespace KParts;' to editor.h
* kate/part/katedialogs.moc:259,268,275,281, namespace bug above
  workaround similar to the one above.
* kate/part/katedocument.moc:507,708,730,738, same as above
* kate/part/katefactory.moc, same as above
* kate/part/kateview.moc, same as above
* kate/part/kateviewhighlightaction.moc, same as above
* kate/part/kateexportaction.moc, ditto
* kcert/kcertpart.moc, ditto

["kdelibs.patch" (text/plain)]

diff -Naur kdelibs-3.0beta2.orig/arts/flow/gsl/gslengine.h \
                kdelibs-3.0beta2/arts/flow/gsl/gslengine.h
--- kdelibs-3.0beta2.orig/arts/flow/gsl/gslengine.h	Sat Jan 26 08:51:56 2002
+++ kdelibs-3.0beta2/arts/flow/gsl/gslengine.h	Wed Feb 13 17:24:49 2002
@@ -88,13 +88,13 @@
 {
   const gfloat *values;
   guint		user_flags : 16;
-  const guint	connected : 1;
+  guint	connected : 1;
 };
 struct _GslOStream
 {
   gfloat     *values;
   guint	      user_flags : 16;
-  const guint connected : 1;
+  guint connected : 1;
   guint	      zero_initialize : 1;
 };
 
diff -Naur kdelibs-3.0beta2.orig/arts/flow/gsl/gslglib.h \
                kdelibs-3.0beta2/arts/flow/gsl/gslglib.h
--- kdelibs-3.0beta2.orig/arts/flow/gsl/gslglib.h	Thu Jan  3 12:33:03 2002
+++ kdelibs-3.0beta2/arts/flow/gsl/gslglib.h	Wed Feb 13 17:24:49 2002
@@ -23,6 +23,7 @@
 #include <float.h>
 #include <stddef.h>
 #include <stdarg.h>
+#include <config.h>
 
 #ifdef __cplusplus
 extern "C" {
@@ -157,10 +158,10 @@
 /* GCC does the right thing */
 # undef alloca
 # define alloca(size)   __builtin_alloca (size)
-#elif defined (GLIB_HAVE_ALLOCA_H)
+#elif defined (HAVE_ALLOCA_H)
 /* a native and working alloca.h is there */ 
 # include <alloca.h>
-#else /* !__GNUC__ && !GLIB_HAVE_ALLOCA_H */
+#else /* !__GNUC__ && !HAVE_ALLOCA_H */
 # ifdef _MSC_VER
 #  include <malloc.h>
 #  define alloca _alloca
@@ -173,7 +174,7 @@
 #   endif /* !alloca */
 #  endif /* !_AIX */
 # endif /* !_MSC_VER */
-#endif /* !__GNUC__ && !GLIB_HAVE_ALLOCA_H */
+#endif /* !__GNUC__ && !HAVE_ALLOCA_H */
 
 #define g_alloca(size) alloca (size)
 #define g_newa(struct_type, n_structs)  ((struct_type*) g_alloca (sizeof \
                (struct_type) * (gsize) (n_structs)))
diff -Naur kdelibs-3.0beta2.orig/arts/flow/gsl/gslopnode.h \
                kdelibs-3.0beta2/arts/flow/gsl/gslopnode.h
--- kdelibs-3.0beta2.orig/arts/flow/gsl/gslopnode.h	Sat Jan 26 08:51:57 2002
+++ kdelibs-3.0beta2/arts/flow/gsl/gslopnode.h	Wed Feb 13 17:24:49 2002
@@ -193,6 +193,8 @@
 void _gsl_op_debug    (GslEngineDebugLevel lvl,
 		       const gchar        *format,
 		       ...) G_GNUC_PRINTF (2,3);
+#else
+#define OP_DEBUG
 #endif
 
 void	_op_engine_inc_counter	(guint64	delta);
diff -Naur kdelibs-3.0beta2.orig/arts/flow/gsl/gsltests.c \
                kdelibs-3.0beta2/arts/flow/gsl/gsltests.c
--- kdelibs-3.0beta2.orig/arts/flow/gsl/gsltests.c	Sat Jan 26 08:51:57 2002
+++ kdelibs-3.0beta2/arts/flow/gsl/gsltests.c	Wed Feb 13 17:24:49 2002
@@ -531,7 +531,7 @@
 	}
       } while (f[0] && v[0]);
 
-      gsl_filter_fir_approx (iorder, a, freq, value, n_points);
+      gsl_filter_fir_approx (iorder, a, n_points, freq, value);
       g_print ("FIR%u(z)=%s\n", iorder, gsl_poly_str (iorder-1, a, "z"));
     }
   else if (strncmp (arg, "poly", 4) == 0)
diff -Naur kdelibs-3.0beta2.orig/kdeui/kmenubar.cpp \
                kdelibs-3.0beta2/kdeui/kmenubar.cpp
--- kdelibs-3.0beta2.orig/kdeui/kmenubar.cpp	Fri Feb  8 18:05:23 2002
+++ kdelibs-3.0beta2/kdeui/kmenubar.cpp	Wed Feb 13 17:24:49 2002
@@ -112,7 +112,7 @@
     // why is this still needed? (Simon)
     if ( d->topLevel && isVisible() )
 	return;
-    return QMenuBar::show();
+    QMenuBar::show();
 }
 
 void KMenuBar::slotReadConfig()
diff -Naur kdelibs-3.0beta2.orig/khtml/dom/dom_element.cpp \
                kdelibs-3.0beta2/khtml/dom/dom_element.cpp
--- kdelibs-3.0beta2.orig/khtml/dom/dom_element.cpp	Thu Jan 10 14:55:12 2002
+++ kdelibs-3.0beta2/khtml/dom/dom_element.cpp	Wed Feb 13 17:24:49 2002
@@ -151,7 +151,7 @@
 
 void Element::removeAttribute( const DOMString &name )
 {
-    return removeAttributeNS(DOMString(), name);
+    removeAttributeNS(DOMString(), name);
 }
 
 Attr Element::getAttributeNode( const DOMString &name )
diff -Naur kdelibs-3.0beta2.orig/kio/kio/kfilemetainfo.h \
                kdelibs-3.0beta2/kio/kio/kfilemetainfo.h
--- kdelibs-3.0beta2.orig/kio/kio/kfilemetainfo.h	Tue Jan 29 10:46:50 2002
+++ kdelibs-3.0beta2/kio/kio/kfilemetainfo.h	Wed Feb 13 17:24:49 2002
@@ -255,7 +255,6 @@
      **/
     KFilePlugin * const plugin() const;
 
-    class Data;
     Data* d;
 };
 
--- kdelibs-3.0beta2.orig/configure.in	Sat Feb  9 08:29:41 2002
+++ kdelibs-3.0beta2/configure.in	Wed Feb 13 17:57:55 2002
@@ -653,7 +653,7 @@
 
 dnl check for IRIX audio support
 AC_MSG_CHECKING([for IRIX])
-if test `uname` = "IRIX" ; then
+if test `uname` = "IRIX" -o `uname` = "IRIX64" ; then
   AC_DEFINE(HAVE_IRIX, 1, [Define if you compile under IRIX])
   AC_MSG_RESULT("yes")
 else


["kdelibs-compiler.patch" (text/plain)]

diff -Naur kdelibs-3.0beta2.orig/interfaces/ktexteditor/editor.h \
                kdelibs-3.0beta2/interfaces/ktexteditor/editor.h
--- kdelibs-3.0beta2.orig/interfaces/ktexteditor/editor.h	Sat Jan 26 08:53:54 2002
+++ kdelibs-3.0beta2/interfaces/ktexteditor/editor.h	Wed Feb 13 17:38:56 2002
@@ -21,6 +21,8 @@
 
 #include <kparts/part.h>
 
+using namespace KParts;
+
 namespace KTextEditor
 {
 
diff -Naur kdelibs-3.0beta2.orig/kate/part/katedialogs.h \
                kdelibs-3.0beta2/kate/part/katedialogs.h
--- kdelibs-3.0beta2.orig/kate/part/katedialogs.h	Sat Feb  2 14:48:28 2002
+++ kdelibs-3.0beta2/kate/part/katedialogs.h	Wed Feb 13 17:38:56 2002
@@ -34,6 +34,8 @@
 #include <qcolor.h>
 #include <qlistview.h>
 
+using namespace Kate;
+
 class QWidgetStack;
 class QVBox;
 class  KListView;
diff -Naur kdelibs-3.0beta2.orig/kate/part/katedocument.h \
                kdelibs-3.0beta2/kate/part/katedocument.h
--- kdelibs-3.0beta2.orig/kate/part/katedocument.h	Sat Feb  2 14:48:28 2002
+++ kdelibs-3.0beta2/kate/part/katedocument.h	Wed Feb 13 17:38:56 2002
@@ -38,6 +38,8 @@
 #include <kglobalsettings.h>
 #include <kspell.h>
 
+using namespace Kate;
+
 class KateCmd;
 
 class Attribute {
diff -Naur kdelibs-3.0beta2.orig/kate/part/kateexportaction.h \
                kdelibs-3.0beta2/kate/part/kateexportaction.h
--- kdelibs-3.0beta2.orig/kate/part/kateexportaction.h	Sat Jan 12 05:47:12 2002
+++ kdelibs-3.0beta2/kate/part/kateexportaction.h	Wed Feb 13 17:38:56 2002
@@ -27,6 +27,8 @@
 #include <qstringlist.h>
 #include <qguardedptr.h>
 
+using namespace Kate;
+
 class KateExportAction: public Kate::ActionMenu
 {
 	Q_OBJECT
diff -Naur kdelibs-3.0beta2.orig/kate/part/katefactory.h \
                kdelibs-3.0beta2/kate/part/katefactory.h
--- kdelibs-3.0beta2.orig/kate/part/katefactory.h	Fri Feb  8 17:49:48 2002
+++ kdelibs-3.0beta2/kate/part/katefactory.h	Wed Feb 13 17:38:56 2002
@@ -24,6 +24,8 @@
 
 #include <kparts/factory.h>
 
+using namespace KParts;
+
 class KInstance;
 class KAboutData;
 
diff -Naur kdelibs-3.0beta2.orig/kate/part/kateview.h \
                kdelibs-3.0beta2/kate/part/kateview.h
--- kdelibs-3.0beta2.orig/kate/part/kateview.h	Fri Jan 25 12:11:48 2002
+++ kdelibs-3.0beta2/kate/part/kateview.h	Wed Feb 13 17:38:56 2002
@@ -35,6 +35,9 @@
 #include <qstring.h>
 #include <qdialog.h>
 
+using namespace KParts;
+using namespace Kate;
+
 class KToggleAction;
 class KActionMenu;
 class KAction;
diff -Naur kdelibs-3.0beta2.orig/kate/part/kateviewhighlightaction.h \
                kdelibs-3.0beta2/kate/part/kateviewhighlightaction.h
--- kdelibs-3.0beta2.orig/kate/part/kateviewhighlightaction.h	Sat Jan 12 05:47:13 \
                2002
+++ kdelibs-3.0beta2/kate/part/kateviewhighlightaction.h	Wed Feb 13 17:38:56 2002
@@ -30,6 +30,8 @@
 #include <qpopupmenu.h>
 #include <qguardedptr.h>
 
+using namespace Kate;
+
 class KateViewHighlightAction: public Kate::ActionMenu
 {
   Q_OBJECT
diff -Naur kdelibs-3.0beta2.orig/kcert/kcertpart.h kdelibs-3.0beta2/kcert/kcertpart.h
--- kdelibs-3.0beta2.orig/kcert/kcertpart.h	Fri Nov  2 09:35:15 2001
+++ kdelibs-3.0beta2/kcert/kcertpart.h	Wed Feb 13 17:38:56 2002
@@ -29,6 +29,8 @@
 #include <qlistview.h>
 #include <klistview.h>
 
+using namespace KParts;
+
 class KSSLCertBox;
 class QFrame;
 class QLabel;


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic