[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Bug#16203: PATCH: Fix KMixApplet for vertical panels
From:       Erik Sigra <sigra () home ! se>
Date:       2001-10-25 21:49:34
[Download RAW message or body]

onsdagen den 24 oktober 2001 14.35 skrev Erik Sigra:
> onsdagen den 24 oktober 2001 01.48 skrev du:
> > On Tuesday 23 October 2001 12:51 pm, Erik Sigra wrote:
> > > This patch fixes the KMixApplet for vertical panels. The bug in
> > > question is now 322 days old so I thought it was time to do something
> > > about it. (The bug page is "http://bugs.kde.org/db/16/16203.html".)
> >
> > The patch causes a segfault in "heightForWidth()" here due to neither
> > m_mixerWidget nor m_errorLabel being non-null.
>
> This should never happen. Could it be that you run another kicker version
> that doesn't call popupDirectionChange when the panel starts (or before the
> first call of heightForWidth)?
>
> > Could it be that the patch shouldn't remove the
> > if (mixer) { m_mixerWidget = ... } block ?
>
> I moved the content of that block to popupDirectionChange and it works with
> 2_2_1_RELEASE. If this new patch doesn't work with KDE_2_2_BRANCH (or what
> your version is called), try to add a call to popupDirectionChange after
> the if (!mixer) { m_errorLabel = ... } block in the constructor. (That
> change might even work for the first version of the patch.)

I would have tried it with KDE_2_2_BRANCH myself but I can't build it.

(make -f Makefile.cvs in kdelibs ends with "***BUG in Autoconf--please 
report*** AC_PROG_LIBTOOL" with autoconf 2.13.)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]