[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/html
From:       George Staikos <staikos () kde ! org>
Date:       2004-11-17 13:42:09
Message-ID: 20041117134209.67D1816D87 () office ! kde ! org
[Download RAW message or body]

CVS commit by staikos: 

Fix crash on destruction.  Might point out a case where wallet isn't dequeued
though...  In that case it would crash in KHTMLPart.  Haven't found a testcase
of this yet.
Also removes a createFolder() on read which is a bit silly.
BUG: 93429
CCMAIL: coolo@kde.org


  M +2 -3      html_formimpl.cpp   1.412


--- kdelibs/khtml/html/html_formimpl.cpp  #1.411:1.412
@@ -85,5 +85,5 @@ HTMLFormElementImpl::HTMLFormElementImpl
 HTMLFormElementImpl::~HTMLFormElementImpl()
 {
-    if (getDocument()) {
+    if (getDocument() && getDocument()->view() && getDocument()->view()->part()) {
         getDocument()->view()->part()->dequeueWallet(this);
     }
@@ -435,5 +435,4 @@ void HTMLFormElementImpl::walletOpened(K
     const QString key = calculateAutoFillKey(*this);
     if (!w->hasFolder(KWallet::Wallet::FormDataFolder())) {
-        if (!w->createFolder(KWallet::Wallet::FormDataFolder()))
             return; // failed
     }


[prev in list] [next in list] [prev in thread] [next in thread]