From kde-commits Wed Nov 17 13:42:09 2004 From: George Staikos Date: Wed, 17 Nov 2004 13:42:09 +0000 To: kde-commits Subject: kdelibs/khtml/html Message-Id: <20041117134209.67D1816D87 () office ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=110069894521164 CVS commit by staikos: Fix crash on destruction. Might point out a case where wallet isn't dequeued though... In that case it would crash in KHTMLPart. Haven't found a testcase of this yet. Also removes a createFolder() on read which is a bit silly. BUG: 93429 CCMAIL: coolo@kde.org M +2 -3 html_formimpl.cpp 1.412 --- kdelibs/khtml/html/html_formimpl.cpp #1.411:1.412 @@ -85,5 +85,5 @@ HTMLFormElementImpl::HTMLFormElementImpl HTMLFormElementImpl::~HTMLFormElementImpl() { - if (getDocument()) { + if (getDocument() && getDocument()->view() && getDocument()->view()->part()) { getDocument()->view()->part()->dequeueWallet(this); } @@ -435,5 +435,4 @@ void HTMLFormElementImpl::walletOpened(K const QString key = calculateAutoFillKey(*this); if (!w->hasFolder(KWallet::Wallet::FormDataFolder())) { - if (!w->createFolder(KWallet::Wallet::FormDataFolder())) return; // failed }