[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] final fix for textview probs
From:       aleXXX <alexander.neundorf () gmx ! net>
Date:       2001-08-01 17:28:41
[Download RAW message or body]

On Wednesday 01 August 2001 18:14, Waldo Bastian wrote:
> On Wednesday 01 August 2001 08:53 am, aleXXX wrote:
> > My suggestion: if the user starts to select something using the mouse,
> > check whether he already explicitely selected some files (e.g. using
> > Insert, shift/ctrl+down/up/...). If this is the case and the user uses
> > CTRL+mousebutton to select, keep the former selection and add the new
> > items. If he didn't explicitely select files, but the current file is
> > selected simply because it is the current item, deselect this one first
> > and then add the new selected items. Therefor we need a new method
> > bool KListView::isSomethingExplicitlySelected()
> >    {return !d->selectedBySimpleMove};
>
> That would be an invisible state like "this items is being shown as
> selected, but it is selected differently as other items but you can't see
> this difference". I don't think that's a very good idea in general.

Hmm, it behaves this way since 2.0 or 2.1, I'm not sure, so you could know 
how it feels ;-)
The point is, if the current item is not selected, you have first to select 
it using space if you want to delete it or if you want to open the RMB menu 
for this file. This is very inconvinient.
That's why in konqy the current item is also selected.
Now if a user selects some files additionally, e.g. using Insert, and then 
moves the cursor around, the current item is no longer automatically 
selected. IMHO this feels not bad :-)
This helps against the problems I usually have e.g. in midnight commander, 
there I never know if I selected some files and move the "cursor" to another 
file and then e.g. delete the files, whether the current file is also deleted 
or only the selected ones.
With the current konqy behaviour this is IMO obvious, the selected items are 
deleted, if you didn't select any but only moved around, the current item is 
deleted (since this is selected automatically).
Now if  I have split konqy into some views and change between the views and 
didn't select any files in one view, the selection bar in the former view 
disappears and appears in the view where I switched to. This makes it easier 
to recognize which view is the active one.
Now the text list view in konqy additionally automatically selects the 
current item if a directory is entered. Not everybody likes it this way, but 
I do and I implemented it. And this happens also only for the text list view. 
So if somebody doesn't like this, he can use the detailed list view :-)


> Unfortunately I fail to fully understand the old situation and what Michael
> changed about it so I may not be in the best position to judge this.

He mainly disabled the "the selection bar disappears when I leave a view and 
comes back when I enter the view" and he introduced a new current item 
"style", which might be confused with the selected item "style".

Please revert the patch and let's fix it correctly after 2.2.

Bye
Alex

[prev in list] [next in list] [prev in thread] [next in thread]