[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] final fix for textview probs
From:       aleXXX <alexander.neundorf () gmx ! net>
Date:       2001-08-01 15:56:40
[Download RAW message or body]

On Wednesday 01 August 2001 10:14, Michael Brade wrote:
> Hi!
>
> This night I thought about the problem again and came to the following
> conclusion:
>
> The current behaviour of the textview to only change the current item if
> the focus change happens between the parts in one specific Konqywindow is
> inconsistent. Furthermore this led to the problems described in #29530 and
> would result in a workaround (aka evil hacks) for mouseselections.
>
> To fix those bugs and make AleXXX happy at the same time ;) I just changed
> the paintFocus method for the textview items. Like this we have now the
> visible focus change without the need to really select an item and can even
> save some code-duplication in the textviewwidget. The behaviour of all
> listviews is now exactly the same and consistent all over the place, only
> the look&feel is different.
>
> If nobody (especially Alex) objects I'll commit at about 15:00 CEST because
> I'll have to leave for about 6 days then. And then I can only pray that
> this change still makes it into KDE 2.2....
>
> Ciao,
>   Michael

And one more thing:

in klistview.cpp:

@@ -518,19 +508,6 @@ void KListView::focusOutEvent( QFocusEve
   cleanDropVisualizer();
   cleanItemHighlighter();
 
-  d->autoSelect.stop();
-
-  if ((d->selectedBySimpleMove)
-      && (d->selectionMode == Konqueror)
-      && (fe->reason()!=QFocusEvent::Popup)


are you sure removing d->autoSelect.stop(); is ok ?
this line must be for something else, not for keyboard selection in konqy, I 
don't know, it is not "my line".

Bye
Alex

[prev in list] [next in list] [prev in thread] [next in thread]