[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] final fix for textview probs
From:       aleXXX <alexander.neundorf () gmx ! net>
Date:       2001-08-01 15:53:43
[Download RAW message or body]

On Wednesday 01 August 2001 10:14, Michael Brade wrote:
> Hi!
>
> This night I thought about the problem again and came to the following
> conclusion:
>
> The current behaviour of the textview to only change the current item if
> the focus change happens between the parts in one specific Konqywindow is
> inconsistent. Furthermore this led to the problems described in #29530 and
> would result in a workaround (aka evil hacks) for mouseselections.
>
> To fix those bugs and make AleXXX happy at the same time ;) I just changed
> the paintFocus method for the textview items. Like this we have now the
> visible focus change without the need to really select an item and can even
> save some code-duplication in the textviewwidget. The behaviour of all
> listviews is now exactly the same and consistent all over the place, only
> the look&feel is different.
>
> If nobody (especially Alex) objects I'll commit at about 15:00 CEST because
> I'll have to leave for about 6 days then. And then I can only pray that
> this change still makes it into KDE 2.2....
>
> Ciao,
>   Michael

Well, I do object, I couldn't read my mail earlier.

With your patch (ok, I didn't compile and try, but I'm sure I understood it) 
the behaviour is the following:
I enter one dir, no item is selected, I move down using the keyboard, the 
next item is selected. I switch to the next view, the item stays selected 
(without that I explicitely selected it).
In the textview now the current item looks different ( "is this thing 
selected ?")

To be honest, I really don't like your patch. I intentionally implemented the 
behaviour as it was, using the keyboard only it works nearly perfect (I use 
it all the time and don't experience any bugs).
Problems might occur when using the mouse, e.g. to select files. So there is 
the point where the stuff has to be fixed.
My suggestion: if the user starts to select something using the mouse, check 
whether he already explicitely selected some files (e.g. using Insert, 
shift/ctrl+down/up/...). If this is the case and the user uses 
CTRL+mousebutton to select, keep the former selection and add the new items.
If he didn't explicitely select files, but the current file is selected 
simply because it is the current item, deselect this one first and then add 
the new selected items. Therefor we need a new method
bool KListView::isSomethingExplicitlySelected() 
   {return !d->selectedBySimpleMove};

IMHO this is to late for 2.2, let's sort it out if cvs is unfrozen again.
So, please revert your patch if you already applied it.
(I'm currently not subscribed to kde-cvs)

If a user doesn't like the behaviour of the text list view, he can use the 
detailed view, that's why we have different views :-)

Bye
Alex

[prev in list] [next in list] [prev in thread] [next in thread]