[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: New SASL library
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2001-06-29 12:45:06
[Download RAW message or body]

On Thursday 28 June 2001 14:33, Michael Häckel wrote:
> Hi,
>
> Attached a new SASL library. It has basically the same functionality as the
> old one plus LOGIN authentication. It is completely rewritten from scrach
> according to the instructions given in the RFCs.
> I might add DIGEST-MD5 later.
>
> You also find the patch to make the pop3 io slave using it, for the case
> someone want's to test it. I don't want to change the pop3 and the imap
> slave to use that library before KDE 2.2, since they currently also work
> very well without it.
>
> However the smtp slave could be ported to use this library. It is anyway
> currently not compiled by default, because it doesn't compile at all.
>
> My questions:
> Where should this library go?
> Again into a subdirectory of kdelibs/kio or directely into a kdelibs
> subdir? The name is slightly different from the name of the old library, so
> there should be no problem.
> Shall it again be a separate library or join another library? The .so file
> has currently 20KB. Well, the old one were even four .so files :-)
> Can it go into CVS immediately, if it is not used by any code, that is
> going to be released with KDE 2.2?
>

Hi Michael,

Good work.  I have several suggestion regarding the use of KMD5.  You do not
need to create multiple instances of this object like you do with the C implementation.
Simply store the result of you calculation and invoke the reset() method on the
same object to reuse it to do another calculation.  This will reduce the overhead 
of creating multiple MD5 objects :)

Regards,
Dawit A.

[prev in list] [next in list] [prev in thread] [next in thread]