[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: This Week's CVS issues :)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-06-01 22:44:19
[Download RAW message or body]

On Saturday 02 June 2001 00:04, Michael Brade wrote:
> Oops, thanks for the hint and the fix :) But I think to add an emit 
> completed() (and emit started() as well) would be the correct fix. However, a 
> problem could be that an app might do "KDirLister::job()" without testing for 
> the returned job being null. What do you think/should I commit? 

I don't have the big picture anymore... is it sensible that KDirLister emits
completed() without having emitted started() before ? Does it emit started()
for automatic-updates ? Hiding/showing the dot files looks like an automatic update
(it actually uses the same code if showing them, which is sensible).
I'm not sure that emitting completed() in this case (which is manually triggered
by the application anyway, unlike the usual async stuff) is necessary/wanted.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]