[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kaction.cpp
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-05-30 20:07:29
[Download RAW message or body]

On Wednesday 30 May 2001 22:09, Martijn Klingens wrote:
> On Wednesday 30 May 2001 20:28, David Faure wrote:
> > On Wednesday 30 May 2001 17:48, Martijn Klingens wrote:
> > > Attached is a patch for KAction to support iconsets/pixmaps when plugged
> > > into popup menus. A few styles (KDE SGI, Marble, Risc OS and
> > > MegaGradient) break with checkable menu items that have icons. IMO those
> > > styles need to be fixed and KAction should not hide the pixmaps instead.
> > > Besides, some parts of KDE already use checkable menu entries with icons
> > > outside of KAction, so the problems are there already anyway.
> > >
> > > Please review, I can commit myself.
> >
> > What this patch seems to do, is revert the "toggle actions don't have
> > icons" change. I can't see the relation between this and the above
> > description.....
> 
> Well.. If that code was committed recently, then my patch apparently reverts 
> it :) That was not the intention, though. 

Well, look at the patch.....

> I thought the current behaviour was 
> there since long, before menus could display icons in toggled actions. IMO 
> that behaviour is broken, because menus are currently perfectly capable to 
> display those icons (apart from the few mentioned styles).

No, you can't have an icon in a toggle action (since there is a checkmark when the
action is activated).

> Therefore I wanted to enable them, I didn't know that it was a recent change 
> to turn them off instead.

Not recent. Very old.

> So I should revert my local changes, because we don't want icons in toggle 
> actions? Then many other KDE apps need fixing too, toggle actions with 
> actions do exist scattered throughout the code. I actually liked them a lot...

I'm not even sure what you are trying to fix here..... please review your patch
and explain...

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]