[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kaction.cpp
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-05-30 18:28:49
[Download RAW message or body]

On Wednesday 30 May 2001 17:48, Martijn Klingens wrote:
> Attached is a patch for KAction to support iconsets/pixmaps when plugged into 
> popup menus. A few styles (KDE SGI, Marble, Risc OS and MegaGradient) break 
> with checkable menu items that have icons. IMO those styles need to be fixed 
> and KAction should not hide the pixmaps instead. Besides, some parts of KDE 
> already use checkable menu entries with icons outside of KAction, so the 
> problems are there already anyway.
> 
> Please review, I can commit myself.

What this patch seems to do, is revert the "toggle actions don't have icons" change.
I can't see the relation between this and the above description.....

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]