[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdeui/kdialog margin size
From:       Richard Moore <rich () ipso-facto ! freeserve ! co ! uk>
Date:       2001-05-18 23:21:07
[Download RAW message or body]



Ralf Nolden wrote:
> 
> Richard Moore wrote:
> >
> > Ralf Nolden wrote:
> > >
> > > Hi,
> > >
> > > while fixing up modules in kcontrol I noticed that the margin size used
> > > by KDialog is different than the one designer uses. As dialogs are
> > > currently mixed ones done with designer in one module and with KDialog
> > > methods in others, we need to stay consistent with the designer ones
> > > IMHO. What needs to be changed is
> >
> > No, no, no - what needs to be changed is the usage of designer.
> > A margin in of 11 is *way* too big, plus you will break any existing
> > manual layouts.
> 
> Well, Rich, what are we supposed to do ? You know, designer has this as
> a default value on *all* systems. If you want to avoid gui clashes like
> these you need to change kdeui to have the same sizes. You can't use the
> functions of KDialog to do that and those are used in manual layouts
> everywhere. I think this is the only solution to fix this consistantly
> because you will have lots of third party apps that use desinger with
> the default values. The result of KDialog having different values is the
> current mess and I end up fixing even the desinger made dialogs in the
> future. I want to finish the work and I can only temporarily do this
> with fixing manual layouts; how am I going to tell developers that work
> on a windows version of a Qt app that on KDE they need to change the
> layout on *all* of their dialogs again ? Please don't say I should tell
> them to do manual layouts because this is obviously not working. To have
> a consitent look throughout all of the stuff you need to adapt to one
> common solution and the default is 11, not 6. That's clearly a fault on
> our class that uses it that way, fortunately this is easy to fix.

I say fix uic to use KDialog::spacingHint() etc.

> 
> I'm on IRC so if you've got some time now we could meet and discuss
> about it.

Sorry, I had to go out. If you want to discuss this tomorrow evening
I should be able to make it.

Rich.

> 
> Ralf
> --
> Finally, even I have to admit that being myself was the best thing
> that ever could have happened to me. - Le Grand Charmeur
> 
> **********************************
> Ralf Nolden
> 
> The KDevelop Project
> http://www.kdevelop.org
> 
> nolden@kde.org
> rnolden@kdevelop.org
> **********************************

[prev in list] [next in list] [prev in thread] [next in thread]